FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: Add websecurityscanner changes by lqiu96 · Pull Request #8471 · googleapis/google-cloud-java · GitHub

chore: Add websecurityscanner changes - #8471

Closed
lqiu96 wants to merge 2 commits into
mainfrom
main-fix
Closed

chore: Add websecurityscanner changes#8471
lqiu96 wants to merge 2 commits into
mainfrom
main-fix

Conversation

lqiu96 commented Sep 27, 2022

Copy link
Copy Markdown
Member

The *.java changes are found from #8448
The *.proto changes are found from #8449

Looks to have been reverted as part of #8340

lqiu96 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022

snippet-bot Bot commented Sep 27, 2022

Copy link
Copy Markdown

Here is the summary of possible violations 😱

Details

There is a possible violation for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

lqiu96 commented Sep 27, 2022
edited
Loading

Copy link
Copy Markdown
Member Author

Not sure why owlbot is deleting this from README.md

<dependencyManagement>
  <dependencies>
    <dependency>
      <groupId>com.google.cloud</groupId>
      <artifactId>libraries-bom</artifactId>
      <version>26.1.0</version>
      <type>pom</type>
      <scope>import</scope>
    </dependency>
  </dependencies>
</dependencyManagement>

<dependencies>
  <dependency>
    <groupId>com.google.cloud</groupId>
    <artifactId>google-cloud-websecurityscanner</artifactId>
  </dependency>

If you are using Maven without BOM, add this to your dependencies:

Is this intended behavior for owlbot?

It's also adding in the samples/ dir again

Seems to be the behavior from the previous PRs

lqiu96 commented Oct 7, 2022

Copy link
Copy Markdown
Member Author

Closing as it is not an issue any longer: #8448

lqiu96 closed this Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL