chore: fixing missed updates to Release Please branch - #8601
Closed
suztomo wants to merge 14 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ddixit14
approved these changes
Oct 13, 2022
Copy link
Copy Markdown
Contributor
|
Can you please update java-notification version in .release-please-manifest file? And remove snapshot from the root pom? |
Sorry, something went wrong.
ddixit14
self-requested a review
October 13, 2022 21:53
Copy link
Copy Markdown
Member
Author
Given the root pom is not published to Maven Central, I don't think it's needed. What's the problem of having the root pom with snapshot version? |
Sorry, something went wrong.
release-please
Bot
force-pushed
the
release-please--branches--main
branch
from
ed5dbfd to
2e8294c
Compare
October 14, 2022 01:45
suztomo
marked this pull request as draft
October 14, 2022 03:19
Copy link
Copy Markdown
Member
Author
|
Tests all succeeded. No need to merge. |
Sorry, something went wrong.
release-please
Bot
force-pushed
the
release-please--branches--main
branch
7 times, most recently
from
74f27fc to
60ff8c4
Compare
October 14, 2022 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request to update the release please branch #8444.