Add TopicId and SubscriptionId classes by mziccard · Pull Request #984 · googleapis/google-cloud-java · GitHub

This PR adds the TopicId class, thus allowing to create subscriptions for topics that reside in different projects.
This PR also adds the SubscriptionId class that is returned by pubsub.list(topic) and pubsub.listAsync(topic) (thus fixing #978).

/cc @aozarov

…ptions(topic)

Coverage increased (+0.02%) to 81.939% when pulling 54596c0 on mziccard:pubsub-ids into 7857986 on GoogleCloudPlatform:pubsub-alpha.

Not a thorough review by any means but this change looks good to me.

Coverage increased (+0.02%) to 81.939% when pulling b27eb5c on mziccard:pubsub-ids into 7857986 on GoogleCloudPlatform:pubsub-alpha.

Coverage increased (+0.02%) to 81.942% when pulling 67be29c on mziccard:pubsub-ids into 7857986 on GoogleCloudPlatform:pubsub-alpha.

* Add TopicId class and tests. Use TopicId in SubscriptionInfo * Add SubscriptionId class and tests. Use SubscriptionId in listSubscriptions(topic) * Minor javadoc fixes * Add identity for deleted topics

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [3.7.0](googleapis/java-dlp@v3.6.7...v3.7.0) (2022-09-15) ### Features * Add Deidentify action ([#977](googleapis/java-dlp#977)) ([4f43cd5](googleapis/java-dlp@4f43cd5)) ### Bug Fixes * Update DeIdentificationTest ([#976](googleapis/java-dlp#976)) ([661f316](googleapis/java-dlp@661f316)) ### Dependencies * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.11 ([#960](googleapis/java-dlp#960)) ([c66384d](googleapis/java-dlp@c66384d)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.12 ([#969](googleapis/java-dlp#969)) ([586795f](googleapis/java-dlp@586795f)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.13 ([#974](googleapis/java-dlp#974)) ([b37407b](googleapis/java-dlp@b37407b)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.14 ([#982](googleapis/java-dlp#982)) ([8ac525a](googleapis/java-dlp@8ac525a)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#980](googleapis/java-dlp#980)) ([885dc15](googleapis/java-dlp@885dc15)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#984](googleapis/java-dlp#984)) ([8cd0a40](googleapis/java-dlp@8cd0a40)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…984) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.protobuf:protobuf-bom](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf)) | `3.21.7` -> `3.21.8` | [![age](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.8/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.8/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.8/compatibility-slim/3.21.7)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.8/confidence-slim/3.21.7)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>protocolbuffers/protobuf</summary> ### [`v3.21.8`](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.7...v3.21.8) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).

Source-Link: googleapis/synthtool@7a220e2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28

…4.0 (#984)

Source-Link: googleapis/synthtool@7a220e2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28

🤖 I have created a release *beep* *boop* --- ### [1.115.2](googleapis/java-pubsub@v1.115.1...v1.115.2) (2022-02-03) ### Dependencies * **java:** update actions/github-script action to v5 ([#1339](googleapis/java-pubsub#1339)) ([#984](googleapis/java-pubsub#984)) ([9a1cc0e](googleapis/java-pubsub@9a1cc0e)) * update dependency com.google.cloud:google-cloud-core to v2.4.0 ([#986](googleapis/java-pubsub#986)) ([8cdf7a0](googleapis/java-pubsub@8cdf7a0)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.7.0 ([#988](googleapis/java-pubsub#988)) ([8993760](googleapis/java-pubsub@8993760)) * update dependency com.google.errorprone:error_prone_annotations to v2.11.0 ([#983](googleapis/java-pubsub#983)) ([abcbb32](googleapis/java-pubsub@abcbb32)) * update dependency com.google.protobuf:protobuf-java-util to v3.19.3 ([#973](googleapis/java-pubsub#973)) ([13a9f96](googleapis/java-pubsub@13a9f96)) * update dependency com.google.protobuf:protobuf-java-util to v3.19.4 ([#987](googleapis/java-pubsub#987)) ([ff71dc7](googleapis/java-pubsub@ff71dc7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### [1.115.2](googleapis/java-pubsub@v1.115.1...v1.115.2) (2022-02-03) ### Dependencies * **java:** update actions/github-script action to v5 ([#1339](googleapis/java-pubsub#1339)) ([#984](googleapis/java-pubsub#984)) ([e4a09c1](googleapis/java-pubsub@e4a09c1)) * update dependency com.google.cloud:google-cloud-core to v2.4.0 ([#986](googleapis/java-pubsub#986)) ([1328227](googleapis/java-pubsub@1328227)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.7.0 ([#988](googleapis/java-pubsub#988)) ([b9a6f1b](googleapis/java-pubsub@b9a6f1b)) * update dependency com.google.errorprone:error_prone_annotations to v2.11.0 ([#983](googleapis/java-pubsub#983)) ([9d9b18c](googleapis/java-pubsub@9d9b18c)) * update dependency com.google.protobuf:protobuf-java-util to v3.19.3 ([#973](googleapis/java-pubsub#973)) ([ba8ed8f](googleapis/java-pubsub@ba8ed8f)) * update dependency com.google.protobuf:protobuf-java-util to v3.19.4 ([#987](googleapis/java-pubsub#987)) ([087a089](googleapis/java-pubsub@087a089)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Per Google internal cleanup

mziccard added 2 commits May 5, 2016 16:53

Add TopicId class and tests. Use TopicId in SubscriptionInfo

f73e657

Add SubscriptionId class and tests. Use SubscriptionId in listSubscri…

54596c0

…ptions(topic)

mziccard added the api: pubsub Issues related to the Pub/Sub API. label May 5, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2016

aozarov reviewed May 5, 2016
View reviewed changes

Minor javadoc fixes

b27eb5c

mziccard force-pushed the pubsub-ids branch from 6d3a5a3 to b27eb5c Compare May 6, 2016 14:03

Add identity for deleted topics

67be29c

mziccard merged commit 9879a16 into googleapis:pubsub-alpha May 10, 2016

mziccard mentioned this pull request May 10, 2016

What should Subscription.topic return when the topic is deleted #991

Closed

mziccard mentioned this pull request Jul 22, 2016

PubSub.listSubscriptions(topic) returns only names, not full subscriptions #978

Closed

chingor13 pushed a commit that referenced this pull request Jan 6, 2026

chore(deps): update dependency com.google.cloud:libraries-bom to v26.…

ea9f624

…4.0 (#984)

suztomo pushed a commit that referenced this pull request Mar 30, 2026

test(deps): update dependency org.mockito:mockito-core to v4.7.0 (#984 )

87fdaba

lqiu96 pushed a commit that referenced this pull request Apr 1, 2026

test(deps): update dependency org.mockito:mockito-core to v4.7.0 (#984 )

e6cb80f

meltsufin pushed a commit that referenced this pull request Apr 29, 2026

deps(java): update actions/github-script action to v5 (#1339 ) (#984 )

9a1cc0e

meltsufin pushed a commit that referenced this pull request May 1, 2026

deps(java): update actions/github-script action to v5 (#1339 ) (#984 )

e4a09c1

benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026

refactor: Avoid setting empty builders in proto setters (googleapis#984 )

09df44c

Per Google internal cleanup

+              /**
+               * Identity for a Google PubSub subscription. {@code SubscriptionId} objects are returned by the
+               * {@link PubSub#listSubscriptions(String, PubSub.ListOption...)} and
+               * {@link PubSub#listSubscriptionsAsync(String, PubSub.ListOption...)} methods as the same topic

Add TopicId and SubscriptionId classes by mziccard · Pull Request #984 · googleapis/google-cloud-java · GitHub

Uh oh!

Add TopicId and SubscriptionId classes - #984

Add TopicId and SubscriptionId classes#984
mziccard merged 4 commits into
googleapis:pubsub-alphafrom
mziccard:pubsub-ids

mziccard commented May 5, 2016

Uh oh!

coveralls commented May 5, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented May 5, 2016

Uh oh!

coveralls commented May 6, 2016

Uh oh!

coveralls commented May 9, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add TopicId and SubscriptionId classes by mziccard · Pull Request #984 · googleapis/google-cloud-java · GitHub

Uh oh!

Add TopicId and SubscriptionId classes - #984

Add TopicId and SubscriptionId classes#984mziccard merged 4 commits intogoogleapis:pubsub-alphagoogleapis/google-cloud-java:pubsub-alphafrom mziccard:pubsub-idsmziccard/gcloud-java:pubsub-idsCopy head branch name to clipboard

Conversation

mziccard commented May 5, 2016

Uh oh!

coveralls commented May 5, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented May 5, 2016

Uh oh!

coveralls commented May 6, 2016

Uh oh!

coveralls commented May 9, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add TopicId and SubscriptionId classes#984
mziccard merged 4 commits into
googleapis:pubsub-alphafrom
mziccard:pubsub-ids