feat: PNPM workspace by bshaffer · Pull Request #8973 · googleapis/google-cloud-node · GitHub

Migrate to PNPM workspace. This will speed up dependency installation, reduces disk space usage by globally hoisting packages, and provides stricter dependency resolution.

Adds pnpm-workspace.yaml/pnpm-lock.yaml to manage all dependencies.
Adds turbo for caching pnpm compile in unit test environment - the removes ~20 minutes from test runs!
Udated presubmit.yaml and windows-presubmit.yaml to use pnpm install --frozen-lockfile to ensure the pnpm lock files are up-to-date
Modified ci/run_single_test.sh to use PNPM workspace, and ci/run_conditional_tests.sh to bypass deprecations on Node v22.
Removed nested npm execution chains from core/packages/gax/package.json, updated pack-n-play test fixtures
Fixed TypeScript discrepancies to ensure npm run compile passes with new PNPM dependency tree.
Removed package-lock.json from all .gitignore files as a best practice: since PNPM is now the source of truth, package-lock.json should never exist. If a developer accidentally runs npm install out of habit, the untracked lockfile will be highlighted by git status, which will hopefully be enough to indicate the mistake.
Updated CONTRIBUTING.md files to use pnpm install when setting up local development environments.
Updated root package.json to enforce pnpm as the strict package manager via only-allow and Corepack to prevent developers from accidentally running npm install and breaking the workspace

Code Review

This pull request migrates the repository to a pnpm workspace, updating numerous .gitignore and CONTRIBUTING.md files, adjusting CI scripts, and updating generated protobuf files. Feedback on these changes highlights several improvement opportunities: nested npm scripts in gax/package.json should be updated to pnpm, stubbed tests in pack-n-play should be explicitly skipped using it.skip rather than left empty, and relative file: paths in package dependencies should be replaced with the workspace: protocol. Additionally, the reviewer advises against using 'as any' type assertions in apirequest.ts and hapi.ts, recommending instead that workspace dependency versions be aligned or safer type casting be implemented to preserve TypeScript's type safety.

Using as any here discards type safety. If the type mismatch is due to req.headers being typed as IncomingHttpHeaders (where header values can be string | string[] | undefined) and getSingleHeader expecting a specific type, it is safer to cast to the expected type (e.g., string | string[] or string) or handle the undefined case explicitly, rather than using as any.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…into pnpm

…ng minimatch in c8

…ubmit

…pendencies are installed

… update bigtable dependencies

…-up PR

…haustion and restore generator-tests

…ions

…ent CI flakiness

# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

… files

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

bshaffer added 3 commits July 27, 2026 16:38

feat: PNPM workspace

1f82324

update artifacts from tests triggered by file changes

e1435cf

docs: update CONTRIBUTING.md files to use pnpm

addcf5e

bshaffer requested review from a team as code owners July 27, 2026 17:24

bshaffer marked this pull request as draft July 27, 2026 17:24

github-actions Bot requested a review from shivanee-p July 27, 2026 17:24

bshaffer added 4 commits July 27, 2026 17:25

feat: PNPM workspace

1a907dd

update artifacts from tests triggered by file changes

6b4261a

docs: update CONTRIBUTING.md files to use pnpm

cc02a2c

enforce pnpm as the strict package manager in package.json

71e8dfe

bshaffer force-pushed the pnpm branch from addcf5e to 71e8dfe Compare July 27, 2026 17:26

gemini-code-assist Bot reviewed Jul 27, 2026

View reviewed changes

gcf-owl-bot Bot and others added 12 commits July 27, 2026 17:41

🦉 Updates from OwlBot post-processor

ce2a761

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'pnpm' of https://github.com/googleapis/google-cloud-node …

f89b645

…into pnpm

update workflows to use root package,json for pnpm version

61078e3

changes from gemini code review

f3c1766

fix tests

16e2c24

fix pnpm install on github ci

aa6413e

use pnpm install --filter to prevent CI timeouts

8d0e3b8

fix(deps): remove global override for brace-expansion to avoid breaki…

3597303

…ng minimatch in c8

fix(ci): use pnpm install in remaining workflows and fix windows pres…

ff19c45

…ubmit

fix(workspace): add core/* to pnpm-workspace to ensure core/common de…

95c24ff

…pendencies are installed

fix(ci): fix pnpm run --if-present flag position

7b40b70

chore: bump mocha to v11 in node-bootstrap-container to fix tests

3d0168d

bshaffer force-pushed the pnpm branch from e2e7ae3 to 14ea735 Compare July 31, 2026 01:38

test: skip on quota exhaustion during cleanup

5887ffd

bshaffer force-pushed the pnpm branch 2 times, most recently from f0db4b5 to 2f70a84 Compare July 31, 2026 02:23

chore: fix github actions hash pins for zizmor

f7d9329

bshaffer force-pushed the pnpm branch from 2f70a84 to f7d9329 Compare July 31, 2026 03:15

chore: trigger CI

6c89a95

bshaffer force-pushed the pnpm branch from e6cc561 to 6c89a95 Compare July 31, 2026 16:21

bshaffer mentioned this pull request Jul 31, 2026

fix(ci): test script fixes for node 22 and 26 #9038

Merged

This was referenced Aug 11, 2026

chore: remove yargs override in root package.json once all sub-packages are updated #9130

Open

feat(ci): implement sharding for unit test performance #9021

Merged

bshaffer added 4 commits August 13, 2026 08:30

Merge branch 'main' into pnpm

cb9eea4

fix(ci): update pnpm action setup, fix node-version in presubmit, and…

98fd537

… update bigtable dependencies

chore: move .nycrc, Contributing.md, and .gitignore changes to follow…

cb3482d

…-up PR

chore: move remaining Contributing.md changes to follow-up PR

f61b961

bshaffer mentioned this pull request Aug 13, 2026

chore: update .nycrc, Contributing.md, and .gitignore across packages #9144

Draft

bshaffer added 11 commits August 13, 2026 16:29

style: apply linter auto-fixes in storage resumable upload test

1ee52a6

fix(ci): cap turbo compilation concurrency to prevent Windows heap ex…

12ebfd2

…haustion and restore generator-tests

fix: set turbo concurrency to 4 in package.json

6e2de67

fix(gax): remove nested npm i calls in prepare scripts

f65d7d0

test(bigtable): use dynamic port in MockServer to prevent port collis…

819f05d

…ions

test(bigtable): increase timeout for streaming readrows tests to prev…

1d97a1f

…ent CI flakiness

fix: correct pnpm install indentation across kokoro scripts

ecd5915

chore: restore engines.node >=22 in dev-packages

d795bd9

Merge remote-tracking branch 'origin/main' into pnpm

6858590

# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

chore: update pnpm-lock.yaml with packages from main

53447c8

fix: correctly check directory prefix for windows test exemptions

3d6b073

bshaffer marked this pull request as ready for review August 14, 2026 06:40

bshaffer and others added 2 commits August 14, 2026 17:49

chore: revert non-essential pnpm.overrides removals from package.json…

a78756e

… files

🦉 Updates from OwlBot post-processor

6a3e656

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

                   .setUrl(urlString)
-                  .setUserAgent(getSingleHeader(req!.headers['user-agent']))
-                  .setReferrer(getSingleHeader(req!.headers.referrer))
+                  .setUserAgent(getSingleHeader(req!.headers['user-agent'] as any))
+                  .setReferrer(getSingleHeader(req!.headers.referrer as any))
                   .setStatusCode(attemptToExtractStatusCode(req!))

feat: PNPM workspace by bshaffer · Pull Request #8973 · googleapis/google-cloud-node · GitHub

Uh oh!

feat: PNPM workspace - #8973

feat: PNPM workspace#8973
bshaffer wants to merge 104 commits into
mainfrom
pnpm

bshaffer commented Jul 27, 2026 •
edited
Loading

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot Jul 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

feat: PNPM workspace by bshaffer · Pull Request #8973 · googleapis/google-cloud-node · GitHub

Uh oh!

feat: PNPM workspace - #8973

feat: PNPM workspace#8973bshaffer wants to merge 104 commits intomaingoogleapis/google-cloud-node:mainfrom pnpmgoogleapis/google-cloud-node:pnpmCopy head branch name to clipboard

Conversation

bshaffer commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

feat: PNPM workspace#8973
bshaffer wants to merge 104 commits into
mainfrom
pnpm

bshaffer commented Jul 27, 2026 •
edited
Loading