FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(storage): fix document of delete blob by HemangChothani · Pull Request #10015 · googleapis/google-cloud-python · GitHub

fix(storage): fix document of delete blob - #10015

Merged
crwilcox merged 2 commits into
googleapis:masterfrom
MaxxleLLC:storage_fix_doc_blob_delete
Jan 10, 2020
Merged

fix(storage): fix document of delete blob#10015
crwilcox merged 2 commits into
googleapis:masterfrom
MaxxleLLC:storage_fix_doc_blob_delete

Conversation

Copy link
Copy Markdown
Contributor

Fixes #9985

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 24, 2019

frankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, as there shouldn't be a return value on deletes.

Additionally, the API does not return the object resource on a delete operation as well.
https://cloud.google.com/storage/docs/json_api/v1/objects/delete

crwilcox merged commit 3bb565b into googleapis:master Jan 10, 2020
This was referenced Jan 29, 2020
HemangChothani deleted the storage_fix_doc_blob_delete branch January 31, 2020 12:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage: Blob.delete returns self.bucket.delete_blob but delete_blob returns nothing

5 participants


Back | FazBrowse Home | New Git URL