fix(bigquery): write pandas datetime[ns] columns to BigQuery TIMESTAMP columns - #10028
Merged
plamut merged 8 commits intoJan 11, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tswast
force-pushed
the
issue9996-load_table_from_dataframe-sample-tests
branch
from
e10f755 to
ee48df8
Compare
January 2, 2020 20:32
…P columns Also: * Enable TIMESTAMP and DATETIME unit tests for `_pandas_helpers`. * Add more data types to load dataframe sample.
tswast
force-pushed
the
issue9996-load_table_from_dataframe-sample-tests
branch
from
ee48df8 to
6965558
Compare
January 2, 2020 23:13
tswast
marked this pull request as ready for review
January 2, 2020 23:18
Pandas doesn't automatically convert datetime objects to UTC time, so show how to do this in the code sample.
Copy link
Copy Markdown
Contributor
Author
|
Failure is for the docs session and appears to be just a temporary flake with the gax docs. sphinx.errors.SphinxWarning: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://gax-python.readthedocs.org/en/latest/objects.inv' not fetchable due to <class 'requests.exceptions.ConnectionError'>: HTTPSConnectionPool(host='gax-python.readthedocs.org', port=443): Max retries exceeded with url: /en/latest/objects.inv (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x7fdef467d050>: Failed to establish a new connection: [Errno 110] Connection timed out'))
|
Sorry, something went wrong.
plamut
suggested changes
Jan 9, 2020
plamut
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
We need to fix an undefined name that causes the snippets and lint checks to fail. Seems good otherwise.
Sorry, something went wrong.
Comment thread
bigquery/samples/tests/test_load_table_dataframe.py
plamut
approved these changes
Jan 11, 2020
plamut
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This was referenced Jan 29, 2020
Merged
This was referenced Jan 29, 2020
Merged
Merged
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also:
Fixes #9996 🦕