doc(bigquery): uncomment Client constructor and imports in samples - #10058
Merged
tswast merged 3 commits intoJan 3, 2020
Merged
doc(bigquery): uncomment Client constructor and imports in samples#10058tswast merged 3 commits into
tswast merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Use a session-scope filter to ensure that a client is only constructed once per test run, saving time on authentication.
shollyman
approved these changes
Jan 3, 2020
shollyman
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good, but my mind may have been lulled into a sense of complacency by the repetition of the word "client" in the diffs. :)
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks! Yeah, it's mostly a search-and-replace. Only manual changes were to conftest.py. |
Sorry, something went wrong.
This was referenced Jan 29, 2020
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a session-scope filter to ensure that a client is only constructed once per test run, saving time on authentication.
We received customer feedback (internal issue 144569827) pointing out that the Client constructor and from google.cloud import bigquery lines shouldn't be commented-out. Leaving these uncommented also better matches the latest code sample best practices. To ensure this is net-neutral in terms of test time, I update the client fixture to ensure that bigquery.Client() in the code samples doesn't redo the slow authentication logic.