| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Testing for "is (not) PY2" instead of "is (not) PY3" is indeed more robust, thanks for catching that!
Sorry, something went wrong.
The change is done to an auto-generated file
There was a problem hiding this comment.
(speaking for the PubSub library)
The change is good, but needs to be made in the synth file that is used to generate the file changed here.
The changes to the files in other libraries are fine, as those files are not auto-generated (AFAIK).
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM with one final remark.
Sorry, something went wrong.
|
The test failures are not related, also happen on master. Investigating. Update: At least for logging, the test failure is caused by an out-of-date assertion - an optional timeout was added to core recently. Will be fixed in #10087. Update 2: The Storage failures also seem to be a regression, will submit a fix for that, too (edit: submitted). |
Sorry, something went wrong.
…with Python 4 (#10081) * fix: fix for Python 4: replace unsafe six.PY3 with PY2 * Fix wording
…with Python 4 (#10081) * fix: fix for Python 4: replace unsafe six.PY3 with PY2 * Fix wording
…with Python 4 (#10081) * fix: fix for Python 4: replace unsafe six.PY3 with PY2 * Fix wording
| Back | FazBrowse Home | New Git URL |
Fixes #10158.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
(edit by @plamut: opened the issue for better traceability)
We don't yet know if 3.10 or 4.0 will follow Python 3.9, but whichever it is, it will probably happen in 2020 when Python 3.9 reaches beta and work begins on Python 3.9+1.
There's some code which uses six.PY3:
Where:
When run on Python 4, this will run the Python 2 code!
Instead, use six.PY2.
Found using https://github.com/asottile/flake8-2020.