Bringing all environment variables into a single place. - #1010
Merged
dhermes merged 2 commits intoJul 23, 2015
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This is so we can give a quick overview of all environment variables used.
Copy link
Copy Markdown
Contributor
|
I don't object to centralizing them; ISTM that if we do so, it would be to make them "non-private", so maybe remove the leading underscore on the module name / variable names?? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@tseaver What about also axing _ENV_VAR_NAME from all the variables? Also, I'm not sure about making the module public, but happy to make the variables public. Why do you think the module should be? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I was thinking to point to it from user-facing docs on configuring gcloud-python: we don't normally do that for "private" modules. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
SGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@dhermes I don't see any new commits. |
Sorry, something went wrong.
Also renaming all variables in the file to drop the `_ENV_VAR_NAME` post-fix and the leading underscore.
Copy link
Copy Markdown
Contributor
Author
|
@tseaver D'oh! #FAIL by me. Actually pushed the commit now. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
dhermes
added a commit
that referenced
this pull request
Jul 23, 2015
Bringing all environment variables into a single place.
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
* feat: add fields and the BackupType proto for Hot Backups docs: clarify comments and fix typos PiperOrigin-RevId: 658791576 Source-Link: googleapis/googleapis@c93b54f Source-Link: googleapis/googleapis-gen@e52ba38 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTUyYmEzOGE5NWE4MmY3NTg4ZDBkZDNhMjI4NGM5ODg1MGRhYjllMSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
I found this change makes it a bit easier to implement #960.
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
* feat: add fields and the BackupType proto for Hot Backups docs: clarify comments and fix typos PiperOrigin-RevId: 658791576 Source-Link: googleapis/googleapis@c93b54f Source-Link: googleapis/googleapis-gen@e52ba38 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTUyYmEzOGE5NWE4MmY3NTg4ZDBkZDNhMjI4NGM5ODg1MGRhYjllMSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620 <details><summary>pandas-gbq: 0.33.0</summary> ## [0.33.0](googleapis/python-bigquery-pandas@v0.32.0...v0.33.0) (2026-01-05) ### Features * add dry run to the read_gbq function (#979) ([516f986f](googleapis/python-bigquery-pandas@516f986f)) </details> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
Update signing conformance test json file to match with https://togithub.com/googleapis/conformance-tests/blob/main/storage/v1/v4_signatures.json; Signature update required in relation to https://togithub.com/googleapis/python-storage/pull/378 Fixes #1010 🦕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is so we can give a quick overview of all environment variables used.
Inspired by the gcloud-* wide discussion of env. vars. I'm not sure if this is worth doing, so @tseaver feel free to shoot this down.
/cc @jgeewax