FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(spanner): fix instance docstrings by IlyaFaer · Pull Request #10106 · googleapis/google-cloud-python · GitHub

docs(spanner): fix instance docstrings - #10106

Merged
IlyaFaer merged 1 commit into
googleapis:masterfrom
MaxxleLLC:spanner_docs_build
Jan 14, 2020
Merged

docs(spanner): fix instance docstrings#10106
IlyaFaer merged 1 commit into
googleapis:masterfrom
MaxxleLLC:spanner_docs_build

Conversation

Copy link
Copy Markdown

Fixes #10099

IlyaFaer added api: spanner Issues related to the Spanner API. type: docs Improvement to the documentation for an API. labels Jan 13, 2020
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 13, 2020
instance.display_name = 'New display name'
instance.node_count = 5
instance.display_name = 'New display name'
instance.node_count = 5

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Because of wrong whitespaces line before calling :meth:`update`. was treated as Python code

IlyaFaer commented Jan 13, 2020
edited
Loading

Copy link
Copy Markdown
Author

Docs with new changes looks okay:

IlyaFaer requested review from larkee and plamut January 13, 2020 11:12
IlyaFaer marked this pull request as ready for review January 13, 2020 11:12

larkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks for fixing this!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spanner: Building the docs fails

3 participants


Back | FazBrowse Home | New Git URL