chore(storage): bump api_core to 1.16.0 - #10110
Closed
jkwlui wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
busunkim96
reviewed
Jan 14, 2020
Comment thread
storage/setup.py
| dependencies = [ | ||
| "google-auth >= 1.9.0, < 2.0dev", | ||
| "google-cloud-core >= 1.1.0, < 2.0dev", | ||
| "google-cloud-core >= 1.16.0, < 2.0dev", |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
It looks like storage depends on google-api-core through google-cloud-core. You'll want to make a release of google-cloud-core that bumps the google-api-core version. https://github.com/googleapis/google-cloud-python/blob/master/core/setup.py
Then you can update this PR with the new google-cloud-core version.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
😛i'm a n00b
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pending #10109 (api_core release)