test(bigquery): add tests for concatenating categorical columns - #10180
Merged
plamut merged 1 commit intoJan 31, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@tswast Friendly ping. :) This PR is probably something than can be reviewed and closed quickly (read: before the repo split tomorrow). |
Sorry, something went wrong.
tswast
approved these changes
Jan 30, 2020
tswast
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Comment thread
bigquery/tests/unit/test_table.py
| bqstorage_client=bqstorage_client, | ||
| dtypes={ | ||
| "col_category": pandas.core.dtypes.dtypes.CategoricalDtype( | ||
| categories=["low", "medium", "high"], ordered=False, |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
[no action required] I suspect there will be users who don't necessarily know the categories ahead of time, though this could trivially be done with a group by / distinct query. If we had a support cookbook, I'd say we should add this info there.
Sorry, something went wrong.
This was referenced Jan 31, 2020
Closed
Closed
[CHANGE ME] Re-generated firestore to pick up changes in the API or client library generator.
#10291
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 2, 2020
Closed
[CHANGE ME] Re-generated translate to pick up changes in the API or client library generator.
#10320
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8044.
This PR adds tests for concatenating multiple-page results that contain categorical column data (both with or without pyarrow available).
It appears that the code already works, provided that a correct explicit categorical dtype is passed to to_dataframe() method.
If dtypes are not specified, a default pandas concatenating behavior results in categorical columns ending up with the dtype "object", but that's already explained in the dtypes parameter's docstring, meaning that the code behaves as advertised.
PR checklist