FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(storage): adjust test assertions to new default timeout by HemangChothani · Pull Request #10251 · googleapis/google-cloud-python · GitHub

chore(storage): adjust test assertions to new default timeout - #10251

Merged
plamut merged 1 commit into
googleapis:masterfrom
MaxxleLLC:storage_test_assertion
Jan 30, 2020
Merged

chore(storage): adjust test assertions to new default timeout#10251
plamut merged 1 commit into
googleapis:masterfrom
MaxxleLLC:storage_test_assertion

Conversation

Copy link
Copy Markdown
Contributor

Fixes #10250

This PR adjusts a few unit test assertions to the new default timeout in core.

How to test

  • Run unit tests on the latest master branch.

Actual result (before the fix):
One test failed due to the timeout argument mismatch.

Expected result (after the fix):
All tests pass.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2020

plamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, thanks for taking care of that in the storage lib!

plamut merged commit 88e060f into googleapis:master Jan 30, 2020
plamut added the api: storage Issues related to the Cloud Storage API. label Jan 30, 2020
This was referenced Jan 30, 2020
HemangChothani deleted the storage_test_assertion branch January 31, 2020 12:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage: Adjust unit tests to the new default connection timeout in core

3 participants


Back | FazBrowse Home | New Git URL