| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
No problem with this one overall. I wonder if our local UTC should be an alias of pytz.utc, IFF pytz is importable (to avoid having more than one global for the zone). |
Sorry, something went wrong.
|
@tseaver RE: default to using pytz, default to ours. Good call! Code reviews are so useful 😄 I totally overlooked that and it's totally the right way to go. |
Sorry, something went wrong.
|
I figured that dropping pytz was really FBO users who never care about timezones at all: those who do will want it, anyway. |
Sorry, something went wrong.
|
Yeah for sure. |
Sorry, something went wrong.
|
@tseaver I re-pushed the initial commit. Sorry I finished it awhile ago but forgot to push. Wanted to actually test the case that pytz was installed, but it was being too big a PITA to deal with sys.modules. WDYT? |
Sorry, something went wrong.
|
We could add a tox stanza that didn't install it. |
Sorry, something went wrong.
|
What is that? |
Sorry, something went wrong.
|
Oops, I inverted it in my mind: we could add a stanza that tests it w/ pytz installed, e.g.: [testenv:py27_w_extras]
deps =
{[testenv]deps}
pytz |
Sorry, something went wrong.
|
Can we punt on it for this PR and fix address it after? |
Sorry, something went wrong.
|
Sure. The only thing I see which might be gating is we have no explicit test coverage for the _UTC class: do we need it? If not, go ahead and merge. |
Sorry, something went wrong.
|
I added it to test__helpers.py, been in here for awhile. |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
Removing use of pytz module / implementing our own UTC.
🤖 I have created a release \*beep\* \*boop\* --- ## [0.54.0](https://www.github.com/googleapis/gapic-generator-python/compare/v0.53.4...v0.54.0) (2021-10-29) ### Features * generate code snippets by default ([#1044](https://www.github.com/googleapis/gapic-generator-python/issues/1044)) ([e46f443](https://www.github.com/googleapis/gapic-generator-python/commit/e46f443dbeffe16b63f97668801b06189769e972)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Enable snippetgen for the default (non-Ads) templates. This reverts commit 8bdb70931a9ecb1c89fda9608697b0762770bc12 (which was a revert of #1044 and #1055). I've checked that the changes are OK (don't break generation for any APIs) by creating a [tag](https://github.com/googleapis/gapic-generator-python/commits/v0.62.0b1) and running the [presubmit](https://critique.corp.google.com/cl/424921742).
* feat: add experimental GDCH support * use ec key * update comment * Update google/oauth2/gdch_credentials.py * fix * add project, update payload
| Back | FazBrowse Home | New Git URL |
This was inspired by #1009.
Our methods for signing strings with credentials / crypto will likely be moved into oauth2client, so this is a pre-emptive move to avoid having pytz as a dependency for oauth2client.
As an added benefit, we avoid having pytz as a dependency, which helps for people wanting to use gcloud-python on App Engine.
/cc @nathanielmanistaatgoogle