Moving rename() from Blob to Bucket. - #1052
Merged
dhermes merged 1 commit intoAug 12, 2015
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This is to fit the pattern already in place for Bucket.copy_blob. The philosophy being to treat copy and rename as operations associated with the container (Bucket) rather than with the object itself (Blob). Fixes googleapis#1007.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
dhermes
added a commit
that referenced
this pull request
Aug 12, 2015
Moving rename() from Blob to Bucket.
gcf-owl-bot Bot
added a commit
that referenced
this pull request
Jun 3, 2025
Source-Link: googleapis/googleapis@79d04b7 Source-Link: googleapis/googleapis-gen@08507bd Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjA4NTA3YmRiN2I4OTAyMWZmYTBjYjVlNzJhNzgxZjE2NWQ1N2MxZjcifQ==
gcf-owl-bot Bot
added a commit
that referenced
this pull request
Jun 4, 2025
Source-Link: googleapis/googleapis@79d04b7 Source-Link: googleapis/googleapis-gen@08507bd Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjA4NTA3YmRiN2I4OTAyMWZmYTBjYjVlNzJhNzgxZjE2NWQ1N2MxZjcifQ== feat: Update Compute Engine v1 API to revision 20250511 (#1047) Note that this contains an intended breaking change to MachineType.scratchDisks. Googlers: see cl/751378213 and b/416655944 Source-Link: googleapis/googleapis@a9f7da0 Source-Link: googleapis/googleapis-gen@5acff2f Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjVhY2ZmMmZmNDU1YTVlNjhiZjE3YjdlMDFjZGE0ZDcxNmNiZTAyMWYifQ==
gcf-owl-bot Bot
added a commit
that referenced
this pull request
Jun 5, 2025
Source-Link: googleapis/googleapis@79d04b7 Source-Link: googleapis/googleapis-gen@08507bd Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjA4NTA3YmRiN2I4OTAyMWZmYTBjYjVlNzJhNzgxZjE2NWQ1N2MxZjcifQ== feat: Update Compute Engine v1 API to revision 20250511 (#1047) Note that this contains an intended breaking change to MachineType.scratchDisks. Googlers: see cl/751378213 and b/416655944 Source-Link: googleapis/googleapis@a9f7da0 Source-Link: googleapis/googleapis-gen@5acff2f Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjVhY2ZmMmZmNDU1YTVlNjhiZjE3YjdlMDFjZGE0ZDcxNmNiZTAyMWYifQ==
gcf-owl-bot Bot
added a commit
that referenced
this pull request
Jun 5, 2025
Source-Link: googleapis/googleapis@79d04b7 Source-Link: googleapis/googleapis-gen@08507bd Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjA4NTA3YmRiN2I4OTAyMWZmYTBjYjVlNzJhNzgxZjE2NWQ1N2MxZjcifQ== feat: Update Compute Engine v1 API to revision 20250511 (#1047) Note that this contains an intended breaking change to MachineType.scratchDisks. Googlers: see cl/751378213 and b/416655944 Source-Link: googleapis/googleapis@a9f7da0 Source-Link: googleapis/googleapis-gen@5acff2f Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjVhY2ZmMmZmNDU1YTVlNjhiZjE3YjdlMDFjZGE0ZDcxNmNiZTAyMWYifQ==
gcf-owl-bot Bot
added a commit
that referenced
this pull request
Jun 5, 2025
Source-Link: googleapis/googleapis@79d04b7 Source-Link: googleapis/googleapis-gen@08507bd Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjA4NTA3YmRiN2I4OTAyMWZmYTBjYjVlNzJhNzgxZjE2NWQ1N2MxZjcifQ== feat: Update Compute Engine v1 API to revision 20250511 (#1047) Note that this contains an intended breaking change to MachineType.scratchDisks. Googlers: see cl/751378213 and b/416655944 Source-Link: googleapis/googleapis@a9f7da0 Source-Link: googleapis/googleapis-gen@5acff2f Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjVhY2ZmMmZmNDU1YTVlNjhiZjE3YjdlMDFjZGE0ZDcxNmNiZTAyMWYifQ==
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
Source-Link: googleapis/synthtool@e808c98 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e3e7e18255c22d1489258d0374c901c01f9c4fd77a12088670cd73d580aa737 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
* feat: add experimental enterprise cert support * fix test issue * resolve comments
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
🤖 I have created a release *beep* *boop* --- ## [2.7.0](googleapis/google-auth-library-python@v2.6.6...v2.7.0) (2022-06-07) ### Features * add experimental enterprise cert support ([#1052](googleapis/google-auth-library-python#1052)) ([dda7dda](googleapis/google-auth-library-python@dda7dda)) * add experimental GDCH support ([#1022](googleapis/google-auth-library-python#1022)) ([5367aac](googleapis/google-auth-library-python@5367aac)) * Pluggable auth support ([#995](googleapis/google-auth-library-python#995)) ([62daa73](googleapis/google-auth-library-python@62daa73)) ### Bug Fixes * validate urls for external accounts ([#1031](googleapis/google-auth-library-python#1031)) ([61b1f15](googleapis/google-auth-library-python@61b1f15)) ### Reverts * pluggable auth support [#995](googleapis/google-auth-library-python#995) ([#1039](googleapis/google-auth-library-python#1039)) ([513d999](googleapis/google-auth-library-python@513d999)) * revert experimental GDCH support ([#1022](googleapis/google-auth-library-python#1022)) ([#1042](googleapis/google-auth-library-python#1042)) ([c720995](googleapis/google-auth-library-python@c720995)) ### Documentation * fix changelog header to consistent size ([#1046](googleapis/google-auth-library-python#1046)) ([e64d084](googleapis/google-auth-library-python@e64d084)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
Source-Link: googleapis/synthtool@e808c98 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e3e7e18255c22d1489258d0374c901c01f9c4fd77a12088670cd73d580aa737 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
* samples: schema evolution * Add command-line commands * Fix tag for rollback * Make formatting fixes * Formatting fixes * Fix exceptions * fix: Set x-goog-request-params for streaming pull request * Set blunderbuss config to auto-assign issues and PRs * fix: Swap writer and reader schema to correct places in sample
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
* Chore: refactor client.download_blob_to_file (#1052) * Refactor client.download_blob_to_file * Chore: clean up code * refactor blob and client unit tests * lint reformat * Rename _prep_and_do_download * Chore: refactor blob.upload_from_file (#1063) * Refactor client.download_blob_to_file * Chore: clean up code * refactor blob and client unit tests * lint reformat * Rename _prep_and_do_download * Refactor blob.upload_from_file * Lint reformat * feature: add 'command' argument to private upload/download interface (#1082) * Refactor client.download_blob_to_file * Chore: clean up code * refactor blob and client unit tests * lint reformat * Rename _prep_and_do_download * Refactor blob.upload_from_file * Lint reformat * feature: add 'command' argument to private upload/download interface * lint reformat * reduce duplication and edit docstring * feat: add support for custom headers starting with metadata op * add custom headers to downloads in client blob modules * add custom headers to uploads with tests * update mocks and tests * test custom headers support tm mpu uploads * update tm test * update test --------- Co-authored-by: MiaCY <97990237+MiaCY@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fit the pattern already in place for Bucket.copy_blob. The philosophy being to treat copy and rename as operations associated with the container (Bucket) rather than with the object itself (Blob).
Fixes #1007.