FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adding gRPC stubs to Bigtable clients by dhermes · Pull Request #1154 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Adding gRPC stubs to Bigtable clients - #1154

Merged
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:grpc-stubs-in-client
Nov 17, 2015
ConversationCommits (3)ChecksFiles changed
Merged

Adding gRPC stubs to Bigtable clients#1154
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:grpc-stubs-in-client

Conversation

dhermes commented Sep 24, 2015

Copy link
Copy Markdown
Contributor

NOTE: Uses #1153 as diffbase

dhermes added the api: bigtable Issues related to the Bigtable API. label Sep 24, 2015
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2015
dhermes force-pushed the grpc-stubs-in-client branch 2 times, most recently from e33fe3d to 3e97689 Compare September 29, 2015 20:28

dhermes commented Sep 29, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver Rebased on top of `master. PTAL.

dhermes reviewed Sep 29, 2015
View reviewed changes
Comment thread setup.py Outdated

This comment was marked as spam.

Sign in to view

dhermes force-pushed the grpc-stubs-in-client branch from 3e97689 to e68a114 Compare September 30, 2015 02:53

dhermes commented Oct 1, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver PTAL. (So you can at least get a feel for how stubs are created and how they work.)

dhermes commented Oct 14, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver We should either get this in or move forward with the sub-package discussion in #1159

Letting both languish is no bueno

tseaver commented Oct 14, 2015

Copy link
Copy Markdown
Contributor

What would be smoothest? I dropped off reviewing this one because it seemed like #1159 was the Right Thing(TM) for dealing with the wonky gRPC dependency. I can go ahead an review here, with the notion that we will split out the per-API projects later.

dhermes commented Oct 15, 2015

Copy link
Copy Markdown
Contributor Author

I think #1159 would be smoothest. If we decide NOT to split out into sub-packages then we can revive this.

dhermes mentioned this pull request Nov 8, 2015
Closed
2 tasks

dhermes commented Nov 15, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver Can we resume review of this per #1212?

tseaver reviewed Nov 16, 2015
View reviewed changes
Comment thread gcloud/bigtable/client.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Add stubs to Bigtable Client class.
a6320af 
For now, just adding custom getters which will tell users
whether the Client has been started. Commit to add
methods to actually make the stubs and start the Client will
be forthcoming.
Adding ability to start/stop clients.
32c4c95 
This creates gRPC stubs for talking to each Bigtable
service needed by the client.
dhermes force-pushed the grpc-stubs-in-client branch from e68a114 to 32c4c95 Compare November 16, 2015 23:10
Adding comment about gRPC stubs context managers.
9cd7022 
In particular, explaining why we __enter__ them but
have no corresponding __enter__ for our users.

dhermes commented Nov 16, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver PTAL. I added a comment in the 3rd commit.

tseaver commented Nov 17, 2015

Copy link
Copy Markdown
Contributor

LGTM.

dhermes added a commit that referenced this pull request Nov 17, 2015
Merge pull request #1154 from dhermes/grpc-stubs-in-client
5d589a1 
Adding gRPC stubs to Bigtable clients
dhermes merged commit 5d589a1 into googleapis:master Nov 17, 2015
dhermes deleted the grpc-stubs-in-client branch November 17, 2015 01:35
dhermes mentioned this pull request Jan 25, 2016
Merged
parthea added a commit that referenced this pull request Nov 24, 2025
chore: sort query params in rest unit tests (#1155)
d313b52 
I've confirmed that the unit tests in python-compute are still passing with this change.

Fixes #1154
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore(python): fix docs publish build (#1154)
1520c5e 
Source-Link: googleapis/synthtool@bd9ede2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:04c35dc5f49f0f503a306397d6d043685f8d2bb822ab515818c4208d7fb2db3a

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
parthea added a commit that referenced this pull request Mar 2, 2026
feat: add use_topic_schema for Cloud Storage Subscriptions (#1154)
8aabc96 
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: mukund-ananthu <83691193+mukund-ananthu@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Mar 6, 2026
chore(deps): update dependency ipython [security] (#1154)
6e645f5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL