FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

#1186: Revendor apitools as 'gcloud._apitools' by tseaver · Pull Request #1189 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

#1186: Revendor apitools as 'gcloud._apitools' - #1189

Merged
tseaver merged 5 commits into
googleapis:masterfrom
tseaver:revendor_apitools_as_gcloud__apitools
Oct 23, 2015
ConversationCommits (5)ChecksFiles changed
Merged

#1186: Revendor apitools as 'gcloud._apitools'#1189
tseaver merged 5 commits into
googleapis:masterfrom
tseaver:revendor_apitools_as_gcloud__apitools

Conversation

tseaver commented Oct 19, 2015

Copy link
Copy Markdown
Contributor

Towards #1186.

Subsequent work to include:

  • From-scratch unit test coverage -> 100%.
  • Renamings to match coding standards.
  • Full lint compliance.
  • Folding in the current gcloud.storage.batch implementation.

tseaver added api: storage Issues related to the Cloud Storage API. packaging hygiene labels Oct 19, 2015
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2015
tseaver mentioned this pull request Oct 19, 2015
Merged

dhermes commented Oct 20, 2015

Copy link
Copy Markdown
Contributor

I'll try to get to these tonight if I can spare a few minutes. I'm 100% occupied during the day (9am-6pm).

tseaver commented Oct 20, 2015

Copy link
Copy Markdown
Contributor Author

No worries. This is slog-work, and I've got at least four more hours of it today (coverage for the gcloud._apitools.transfer module). Then cleanups, etc. are likely to keep me busy all week.

dhermes commented Oct 23, 2015

Copy link
Copy Markdown
Contributor

"Scrape in six used modules from apitools." brought them in with no changes?

dhermes commented Oct 23, 2015

Copy link
Copy Markdown
Contributor

LGTM assuming the answer to my question above is yes

tseaver commented Oct 23, 2015

Copy link
Copy Markdown
Contributor Author

d60a679 really did just copy them in. The remaining commits are the minimum to get the code usable / used within gcloud.storage:

  • e4ab851 rewrites imports from apitools.base.py -> gcloud._apitools.
  • d2e4f99 updates gcloud.storage to use the forked code.
  • b8b2766 and ad1ab44 turn off coverage / lint on the forked code until we get done with cleanups.

tseaver added a commit that referenced this pull request Oct 23, 2015
Merge pull request #1189 from tseaver/revendor_apitools_as_gcloud__ap…
ddb8d20 
…itools

#1186: Revendor apitools as 'gcloud._apitools'
tseaver merged commit ddb8d20 into googleapis:master Oct 23, 2015
tseaver deleted the revendor_apitools_as_gcloud__apitools branch October 23, 2015 20:26
This was referenced Nov 6, 2015
Closed
Merged
dhermes mentioned this pull request Jan 25, 2016
Merged
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore(main): release 0.63.1 (#1189)
6e54ace 
🤖 I have created a release *beep* *boop*
---


### [0.63.1](googleapis/gapic-generator-python@v0.63.0...v0.63.1) (2022-02-03)


### Bug Fixes

* disambiguate method names that are reserved in transport classes ([#1187](googleapis/gapic-generator-python#1187)) ([78626d8](googleapis/gapic-generator-python@78626d8))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Nov 26, 2025
feat: Introduce a way to provide scopes granted by user (#1189)
4d50b47 
* feat: Introduce a way to provide scopes granted by user

* nits

* add rt

* update rt
parthea added a commit that referenced this pull request Mar 2, 2026
fix: Suppress warnings caused during pytest runs (#1189)
45f62df 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Mar 6, 2026
chore(main): release 3.0.1 (#1189)
ba8af86 
🤖 I have created a release *beep* *boop*
---


### [3.0.1](googleapis/python-bigquery@v3.0.0...v3.0.1) (2022-03-30)


### Bug Fixes

* **deps:** raise exception when pandas is installed but db-dtypes is not ([#1191](googleapis/python-bigquery#1191)) ([4333910](googleapis/python-bigquery@4333910))
* **deps:** restore dependency on python-dateutil ([#1187](googleapis/python-bigquery#1187)) ([212d7ec](googleapis/python-bigquery@212d7ec))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL