Streaming: add pep8 / pylint goodness - #1210
Merged
tseaver merged 17 commits intoNov 19, 2015
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
5 tasks
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Theres a bit more than PEP8 changes in "Get 'pep8' working on 'gcloud/streaming'." (e.g. dropping request = _Request() and using self.URL in test_transfer.py). No worries though, just an observation, the commit is all good. |
Sorry, something went wrong.
Comment thread
gcloud/streaming/exceptions.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Comment thread
gcloud/streaming/transfer.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
Finished review |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
tseaver
added a commit
that referenced
this pull request
Nov 19, 2015
Streaming: add pep8 / pylint goodness
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
* fix: fix snippet region tags * chore: delete obsolete files * chore: delete old files Co-authored-by: Dov Shlachter <dovs@google.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
* chore: update systest creds * chore: fix unit test
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
* build(python): fix `docs` and `docfx` builds Source-Link: googleapis/synthtool@fac8444 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5ea6d0ab82c956b50962f91d94e206d3921537ae5fe1549ec5326381d8905cfa * apply googleapis/synthtool#1916 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Cathy Ouyang <cathyo@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses #1209 as a base.