FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Refactor 'gcloud.streaming.http_wrapper' exception handling by tseaver · Pull Request #1249 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Refactor 'gcloud.streaming.http_wrapper' exception handling - #1249

Merged
dhermes merged 3 commits into
googleapis:masterfrom
tseaver:1223-refactor_streaming_exception_handling
Nov 30, 2015
ConversationCommits (3)ChecksFiles changed
Merged

Refactor 'gcloud.streaming.http_wrapper' exception handling#1249
dhermes merged 3 commits into
googleapis:masterfrom
tseaver:1223-refactor_streaming_exception_handling

Conversation

tseaver commented Nov 30, 2015

Copy link
Copy Markdown
Contributor
  • Catch only explicitly retryable exceptions, and handle retry count / interval explicitly in make_api_request.
  • Delete the handle_heep_exceptions helper, and the retry_func argument which used it as a default.
  • Rename _rebuild_http_connections -> _reset_http_connections for clarity.

Closes #1223.

Refactor 'gcloud.streaming.http_wrapper' exception handling:
0526605 
- Catch only explicitly retryable exceptions, and handle retry count /
  interval explicitly in 'make_api_request'.

- Delete the 'handle_heep_exceptions' helper, and the 'retry_func'
  argument which used it as a default.

- Rename '_rebuild_http_connections' -> '_reset_http_connections' for
  clarity.

Closes #1223.
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2015

dhermes commented Nov 30, 2015

Copy link
Copy Markdown
Contributor

Happy to see this! I had to peek into this mess a bit for #1248. If they collide for merging, let's stick with this one first.

dhermes reviewed Nov 30, 2015
View reviewed changes
Comment thread gcloud/streaming/http_wrapper.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes commented Nov 30, 2015

Copy link
Copy Markdown
Contributor

Wow this was so much less work than I expected. w00t

tseaver mentioned this pull request Nov 30, 2015
Merged

dhermes commented Nov 30, 2015

Copy link
Copy Markdown
Contributor

LGTM

tseaver commented Nov 30, 2015

Copy link
Copy Markdown
Contributor Author

@dhermes I will merge with pylint failing on Travis, since we are still working out #1248.

dhermes commented Nov 30, 2015

Copy link
Copy Markdown
Contributor

OK. The new commit since I reviewed is due to the ExceptionType as exc keeping exc limited to the except block's scope in Py3k?

dhermes added a commit that referenced this pull request Nov 30, 2015
Merge pull request #1249 from tseaver/1223-refactor_streaming_excepti…
bc181db 
…on_handling

Refactor 'gcloud.streaming.http_wrapper' exception handling
dhermes merged commit bc181db into googleapis:master Nov 30, 2015

dhermes commented Nov 30, 2015

Copy link
Copy Markdown
Contributor

@tseaver Please answer my above question, but I went ahead and merged so I can re-do #1248 so we can get it merged.

tseaver commented Nov 30, 2015

Copy link
Copy Markdown
Contributor Author

The new commit since I reviewed is due to the ExceptionType as exc keeping exc limited to the except block's scope in Py3k?

Yes: it provoked an UnboundLocalError.

tseaver deleted the 1223-refactor_streaming_exception_handling branch November 30, 2015 19:54

dhermes commented Nov 30, 2015

Copy link
Copy Markdown
Contributor

OK Good deal. Thanks.

dhermes mentioned this pull request Jan 25, 2016
Merged
parthea added a commit that referenced this pull request Nov 24, 2025
fix: fix docstring for map fields (#1249)
dfbde95 
* fix: fix docstring for map fields

* chore: format

* chore: fix typing

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Mar 2, 2026
feat(gapic): support mTLS certificates when available (#1249)
03ca701 
feat: update image to
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
parthea pushed a commit that referenced this pull request Mar 2, 2026
chore: librarian release pull request: 20251216T130719Z (#1251)
a1e74dd 
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
<details><summary>google-cloud-bigtable: 2.35.0</summary>

##
[2.35.0](googleapis/python-bigtable@v2.34.0...v2.35.0)
(2025-12-16)

### Features

* add basic interceptor to client (#1206)
([6561cfac](googleapis/python-bigtable@6561cfac))

* Add encodings for STRUCT and the Timestamp type
([72dfdc44](googleapis/python-bigtable@72dfdc44))

* add PeerInfo proto in Bigtable API
([72dfdc44](googleapis/python-bigtable@72dfdc44))

* Add Type API updates needed to support structured keys in materialized
views
([72dfdc44](googleapis/python-bigtable@72dfdc44))

* support mTLS certificates when available (#1249)
([ca20219c](googleapis/python-bigtable@ca20219c))

### Bug Fixes

* re-export AddToCell for consistency (#1241)
([2a5baf11](googleapis/python-bigtable@2a5baf11))

* async client uses fixed grace period (#1236)
([544db1cd](googleapis/python-bigtable@544db1cd))

* Deprecate credentials_file argument
([72dfdc44](googleapis/python-bigtable@72dfdc44))

* Add ReadRows/SampleRowKeys bindings for materialized views
([72dfdc44](googleapis/python-bigtable@72dfdc44))

* retry cancelled errors (#1235)
([e3fd5d86](googleapis/python-bigtable@e3fd5d86))

</details>
parthea pushed a commit that referenced this pull request Mar 6, 2026
chore(deps): update dependency grpcio to v1.46.1 (#1249)
b2025b3
parthea pushed a commit that referenced this pull request Mar 9, 2026
feat: add connection variable for ignoring transaction warnings (#1249)
4c7b1d9 
Adds a connection variable for ignoring transaction warnings. Also adds
a **kwargs argument to the connect function. This will be used for
further connection variables in the future.

Fixes googleapis/python-spanner-sqlalchemy#494
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL