Returning ints from BigQuery Table.num_rows/num_bytes. - #1252
Merged
dhermes merged 1 commit intoDec 1, 2015
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Do we need to add / update tests exercising the int conversion? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Good call. I was peeling off my notes robotically and it didn't occur to me. |
Sorry, something went wrong.
Also fixing Table.expires docstring typo.
dhermes
force-pushed
the
bigquery-int-values
branch
from
b87d566 to
5c253ec
Compare
December 1, 2015 00:55
Copy link
Copy Markdown
Contributor
Author
|
@tseaver Rebased and added two tests. They are a bit over-loaded: in reality they each contain 4 itty bitty tests. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
dhermes
added a commit
that referenced
this pull request
Dec 1, 2015
Returning ints from BigQuery Table.num_rows/num_bytes.
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
* test: add mock server tests * chore: move to testing folder + fix formatting * refactor: move mock server tests to separate directory * feat: add database admin service Adds a DatabaseAdminService to the mock server and sets up a basic test case for this. Also removes the generated stubs in the grpc files, as these are not needed. * test: add DDL test * test: add async client tests * chore: remove async + add transaction handling * chore: cleanup * perf: remove repeated GetSession calls for FixedSizePool Add a _last_use_time to Session and use this to determine whether the FixedSizePool should check whether the session still exists, and whether it should be replaced. This significantly reduces the number of times that GetSession is called when using FixedSizePool. * chore: run code formatter * chore: revert to utcnow() * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: update _last_use_time in trace_call * chore: fix formatting * fix: remove unnecessary update of _last_use_time --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixing Table.expires docstring typo.