FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adding primitive Bigtable garbage collection rule classes. by dhermes · Pull Request #1290 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Adding primitive Bigtable garbage collection rule classes. - #1290

Merged
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:bigtable-add-gc-rule
Dec 17, 2015
ConversationCommits (2)ChecksFiles changed
Merged

Adding primitive Bigtable garbage collection rule classes.#1290
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:bigtable-add-gc-rule

Conversation

dhermes commented Dec 16, 2015

Copy link
Copy Markdown
Contributor

These are used as settings when creating new column
families within a table.

Also slipping in 3 small Bigtable docstring updates.

dhermes added the api: bigtable Issues related to the Bigtable API. label Dec 16, 2015
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 16, 2015
tseaver reviewed Dec 16, 2015
View reviewed changes
Comment thread gcloud/bigtable/column_family.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes mentioned this pull request Dec 16, 2015
Merged

dhermes commented Dec 16, 2015

Copy link
Copy Markdown
Contributor Author

I am assuming (and am re-implementing under the assumption) that you are more in favor of 13+ subclasses than a class with 13+ arguments (for the filter case). (Here it's simpler since there are only two options.)

tseaver commented Dec 16, 2015

Copy link
Copy Markdown
Contributor

I am assuming (and am re-implementing under the assumption) that you are more in favor of 13+ subclasses than a class with 13+ arguments (for the filter case). (Here it's simpler since there are only two options.)

Exactly, because their implementations will be super-simple / obvious. For the filters, It is also a lot clearer to map the separate classes onto a "syntax tree" when we get around to intersection / union logic.

Adding primitive Bigtable garbage collection rule classes.
92f196d 
These are used as settings when creating new column
families within a table.

Also slipping in 3 small Bigtable docstring updates.
dhermes force-pushed the bigtable-add-gc-rule branch from 4e3f599 to 92f196d Compare December 17, 2015 01:14
dhermes changed the title Adding Bigtable garbage collection rule class. Adding primitive Bigtable garbage collection rule classes. Dec 17, 2015

dhermes commented Dec 17, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver PTAL.

I used _total_seconds from:
https://github.com/GoogleCloudPlatform/gcloud-python/blob/ea4ebb7b87b9ff27ac9cae9cd7c0e5d3ad630dea/gcloud/bigquery/_helpers.py

dhermes commented Dec 17, 2015

Copy link
Copy Markdown
Contributor Author

Looks like https://pypi.python.org/pypi/protobuf/3.0.0b1.post1 (released today) caused Travis to fail:

...
Collecting protobuf>=3.0.0a3
  Downloading protobuf-3.0.0b1.post1.tar.gz (200kB)

dhermes mentioned this pull request Dec 17, 2015
Closed
Pinning on protobuf==3.0.0a3.
d11980f 
Caused by a breakage in latest protobuf release (3.0.0b1.post1).

dhermes commented Dec 17, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver I filed protocolbuffers/protobuf#1056 and pinned to 3.0.0a3 for now. If you like I can pin to it in another PR.

tseaver commented Dec 17, 2015

Copy link
Copy Markdown
Contributor

I used _total_seconds from:
https://github.com/GoogleCloudPlatform/gcloud-python/blob/ea4ebb7b87b9ff27ac9cae9cd7c0e5d3ad630dea/gcloud/bigquery/_helpers.py

Shouldn't we remove that version, and replace it with the new one in gcloud._helpers?

Other than that, LGTM.

dhermes commented Dec 17, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver It's not used anymore, I just remembered we had it before we put all time related stuff in gcloud._helpers.

dhermes added a commit that referenced this pull request Dec 17, 2015
Merge pull request #1290 from dhermes/bigtable-add-gc-rule
f143da2 
Adding primitive Bigtable garbage collection rule classes.
dhermes merged commit f143da2 into googleapis:master Dec 17, 2015
dhermes deleted the bigtable-add-gc-rule branch December 17, 2015 02:26
dhermes mentioned this pull request Dec 31, 2015
Closed
dhermes mentioned this pull request Jan 25, 2016
Merged
parthea added a commit that referenced this pull request Nov 24, 2025
chore(deps): update dependency jinja2 to v3.1.2 (#1290)
acf77f2 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Mar 2, 2026
docs: update urllib3 docstrings for v2 compatibility (#1903)
6f07d22 
Updates docstrings in `google/auth/transport/urllib3.py` to reference
`urllib3.PoolManager` instead of the removed/private
`urllib3.request.RequestMethods`, ensuring compatibility with `urllib3`
v2 documentation standards.

NOTE: This PR supercedes an [older PR
#1290](googleapis/google-auth-library-python#1290),
because some of the content or suggested changes in the older PR are
overtaken by events and/or been incorporated via [other recent
PRs](googleapis/google-auth-library-python#1389).

---
*PR created automatically by Jules for task
[17649723998293325458](https://jules.google.com/task/17649723998293325458)
started by @chalmerlowe*

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
parthea pushed a commit that referenced this pull request Mar 6, 2026
docs(samples): explicitly add bq to samples reqs, upgrade grpc to fix…
9dfa8d1 
… bug on m1 (#1290)

* fix: explicitly add bq to samples reqs, upgrade grpc to fix bug on m1

* update grpc in setup.py

* fix: rm 3.6 constraints, add grpcio to 3.7-3.10 constraints
parthea pushed a commit that referenced this pull request Mar 9, 2026
fix: correct notification error message (#1290)
605a411 
To create a new notification, the notification_id field must be
set to None. Update the error message to clarify this.

Fixes #1289
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL