FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Removing merge.sh. by dhermes · Pull Request #1364 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Removing merge.sh. - #1364

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:remove-merge-sh
Jan 7, 2016
ConversationCommits (1)ChecksFiles changed
Merged

Removing merge.sh.#1364
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:remove-merge-sh

Conversation

dhermes commented Jan 7, 2016

Copy link
Copy Markdown
Contributor

No longer needed since update_wheels_project.sh is gone.

Towards #1123

Removing merge.sh.
2c392b0 
No longer needed since `update_wheels_project.sh` is gone.
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2016

dhermes commented Jan 7, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver At what point do we feel comfortable deleting https://github.com/GoogleCloudPlatform/gcloud-python-wheels

tseaver commented Jan 7, 2016

Copy link
Copy Markdown
Contributor

LGTM

dhermes mentioned this pull request Jan 7, 2016
Closed
8 tasks

dhermes commented Jan 7, 2016

Copy link
Copy Markdown
Contributor Author

Thanks for LGTM. What about my question about deleting the wheels repo?

dhermes added a commit that referenced this pull request Jan 7, 2016
Merge pull request #1364 from dhermes/remove-merge-sh
dafc052 
Removing merge.sh.
dhermes merged commit dafc052 into googleapis:master Jan 7, 2016
dhermes deleted the remove-merge-sh branch January 7, 2016 21:54

tseaver commented Jan 7, 2016

Copy link
Copy Markdown
Contributor

I don't see any reason to keep it: there is no way to go "back in time" for failed Travis builds, or any other such debugging purpose, and I don't think we care about any outside users.

dhermes commented Jan 7, 2016

Copy link
Copy Markdown
Contributor Author

OK. I'm going to set a reminder to do it next Monday (we can discuss at stand-up). The repo will self-destruct in 4 days.

dhermes mentioned this pull request Jan 25, 2016
Merged
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore(main): release 1.1.2 (#1364)
d8d8e23 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Mar 2, 2026
chore(python): conditionally load credentials in .kokoro/build.sh (#1364
b1b0fc6 
)

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
chore(x-goog-request-id): commit testing scaffold (#1366)
9b57500 
* chore(x-goog-request-id): commit testing scaffold

This change commits the scaffolding for which testing
will be used. This is a carve out of PRs #1264 and #1364,
meant to make those changes lighter and much easier to
review then merge.

Updates #1261

* Use guard to keep x-goog-request-id interceptor docile in tests until activation later

* AtomicCounter update

* Remove duplicate unavailable_status that had been already committed into main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL