FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adding cluster argument to Bigtable HappyBase connection. by dhermes · Pull Request #1405 · googleapis/google-cloud-python · GitHub

Adding cluster argument to Bigtable HappyBase connection. - #1405

Merged
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:bigtable-add-cluster-to-happybase
Feb 12, 2016
Merged

Adding cluster argument to Bigtable HappyBase connection.#1405
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:bigtable-add-cluster-to-happybase

Conversation

dhermes commented Jan 21, 2016

Copy link
Copy Markdown
Contributor

@tseaver By adding this I go from 10 to 11 arguments (10 are part of the original interface) and I make pylint angry.


Would you prefer I

  • Use **kwargs for supporting the legacy signature (this breaks any argument order unless we also use *args and manually do the mapping, which would break existing code that uses happybase)
  • Raise the global limit from 10 to 11
  • pylint: disable= locally

@jgeewax How important is having the signature of our gcloud.bigtable.happybase.Connection the same as happybase.Connection?

dhermes added the api: bigtable Issues related to the Bigtable API. label Jan 21, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2016

dhermes commented Jan 28, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver PTAL

dhermes commented Jan 28, 2016

Copy link
Copy Markdown
Contributor Author

@jgeewax PTAL (pending question for you)

dhermes commented Feb 3, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver and @jgeewax PTAL

dhermes force-pushed the bigtable-add-cluster-to-happybase branch from 5166b05 to 9c40113 Compare February 12, 2016 21:25

dhermes commented Feb 12, 2016

Copy link
Copy Markdown
Contributor Author

Resolved with @jgeewax that warnings and kwargs would be better than perfectly good code failing.

Copy link
Copy Markdown
Contributor

LGTM

dhermes added a commit that referenced this pull request Feb 12, 2016
Adding cluster argument to Bigtable HappyBase connection.
dhermes merged commit b30d3f4 into googleapis:master Feb 12, 2016
dhermes deleted the bigtable-add-cluster-to-happybase branch February 12, 2016 22:15
parthea pushed a commit that referenced this pull request Mar 9, 2026
parthea pushed a commit that referenced this pull request Mar 9, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL