Making emulator scripts wait until emulators are ready. - #1417
Merged
dhermes merged 1 commit intoJan 28, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Another option would be to create a process group before calling subprocess, but I haven't tried to implement, so I'm not sure it'll work. |
Sorry, something went wrong.
dhermes
force-pushed
the
emulator-less-flaky
branch
2 times, most recently
from
1de9aaf to
31e6643
Compare
January 27, 2016 03:36
dhermes
force-pushed
the
emulator-less-flaky
branch
2 times, most recently
from
cb8697f to
034d83f
Compare
January 28, 2016 19:52
Also manually handling clean-up of child processes spawned. The ``gcloud`` tool was orphan-ing some processes.
dhermes
force-pushed
the
emulator-less-flaky
branch
from
034d83f to
92d956d
Compare
January 28, 2016 20:13
dhermes
added a commit
that referenced
this pull request
Jan 28, 2016
Making emulator scripts wait until emulators are ready.
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
* add generated sample comment * update golden files * update tests/unit/samplegen/golden_snippets * update tests/snippetgen/goldens * update tests/integration/goldens/eventarc/samples/generated_samples * update golden clients and metadata Co-authored-by: Anthonios Partheniou <partheniou@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also manually handling clean-up of child processes spawned. The gcloud tool was orphan-ing some processes.
NOTE: Has #1400 as diffbase.
Filed googleapis/google-cloud-datastore#87 in response to orphan-ed processes.