Upgrading Makefile to generate datastore v1beta3. - #1428
Merged
dhermes merged 4 commits intoFeb 12, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This LGTM with small nits. |
Sorry, something went wrong.
This is in advance of putting them side-by-side with datastore.
Also - Removing `v1beta2` generated code and `.proto` file - Adding new `.proto` files and generated code - Adding `make_datastore_grpc.py` script to tear out the `protoc` inserted lines by the gRPC plugin - Updating `rewrite_imports.py` to rewrite the datastore imports
Also using subprocess.call instead of check_output in the scripts that split up gRPC from non-gRPC parts of generated modules. This is because check_output swallows standard error and throws a less useful exception.
dhermes
force-pushed
the
change-over-to-v1beta3-protos-2
branch
from
62b83d5 to
dbee5b2
Compare
February 12, 2016 20:19
Copy link
Copy Markdown
Contributor
|
LGTM. |
Sorry, something went wrong.
dhermes
added a commit
that referenced
this pull request
Feb 12, 2016
Upgrading Makefile to generate datastore v1beta3.
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
* fix: Fix remaining REST transport issues This includes: 1) Use message-based transcoding logic instead of dictionary-based. This fixes multiple bugs caused by dict-json-object representation mismatches fro protobuf objects. This also removes a lot of `json->dict->object->proto-plus` object conversion overhead, which was slow and very error-prone. Now all transcodding and rest-transport-specific logic is executed in terms of native protobuf (`_pb`) stubs objects. No dicts, no proto-plus, no unnecessary conversions. 2) Fix for non-proto-plus objects in rest.py transport and in tests. This essential for APIs which have IAM methods defined on their surface. 3) Fix support for Any field in tests 4) Fix creation of mock_values (do `mock_value1` instead of `mock_value_1`, since `mock_value_1` causes issues for FieldMask mocks * update setup template to depend on latest api-core Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
added a commit
that referenced
this pull request
Nov 26, 2025
…1428) * fix: fixes issue where Python37DeprecationWarning cannot be filtered * chore: refresh sys test cred --------- Co-authored-by: arithmetic1728 <58957152+arithmetic1728@users.noreply.github.com> Co-authored-by: Sijun Liu <liusijun1985@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also
Was #1355 but has been re-purposed to merge against the datastore-v1beta3 branch