Adding key_filter to datastore Query. - #1433
Merged
dhermes merged 2 commits intoJan 30, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Also updating system tests and system test helpers to avoid direct use of __key__. Fixes googleapis#1432.
They were using the dataset ID environment variable key rather than the value.
Copy link
Copy Markdown
Contributor
|
LGTM. Are we not-yet-ready-for-primetime on AppVeyor? |
Sorry, something went wrong.
dhermes
added a commit
that referenced
this pull request
Jan 30, 2016
Adding key_filter to datastore Query.
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
This does: 1) fixes LRO method mock value which for watever reason worked under proto 3.x.x (cpp implementaiton) but does not work under proto 4 2) Add `NO COVER` to mock imports in tests as those lines are mutually exclusive depending on the python version it is runniin gunder. Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updating system tests and system test helpers to avoid direct use of __key__.
Fixes #1432.