FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Implementing Row.commit() in Bigtable. by dhermes · Pull Request #1471 · googleapis/google-cloud-python · GitHub

Implementing Row.commit() in Bigtable. - #1471

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:bigtable-row-commit
Feb 15, 2016
Merged

Implementing Row.commit() in Bigtable.#1471
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:bigtable-row-commit

Conversation

dhermes commented Feb 15, 2016

Copy link
Copy Markdown
Contributor

No description provided.

dhermes added the api: bigtable Issues related to the Bigtable API. label Feb 15, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2016
Comment thread gcloud/bigtable/row.py Outdated
def clear_mutations(self):
"""Removes all currently accumulated mutations on the current row."""
if self._filter is None:
self._pb_mutations[:] = []

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Feb 15, 2016

Copy link
Copy Markdown
Contributor Author

FYI @tseaver I am sending another commit to allow a different number of module lines for our test pylint config.

Comment thread gcloud/bigtable/test_row.py Outdated
expected_result = predicate_matched

# Perform the method and check the result.
row.set_cell(column_family_id, column, value, state=True)

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Feb 15, 2016

Copy link
Copy Markdown
Contributor

The pylint change seems OK: maybe disabling too-many-lines altogether for test modules would be better?

dhermes commented Feb 15, 2016

Copy link
Copy Markdown
Contributor Author

I disagree. Exceeding our pre-set limit is always a good signal that we should at least be notified about (even if we choose to ignore it).

dhermes commented Feb 15, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver PTAL, addressed the previous 2 comments

tseaver commented Feb 15, 2016

Copy link
Copy Markdown
Contributor

LGTM pending Travis.

dhermes commented Feb 15, 2016

Copy link
Copy Markdown
Contributor Author

Thanks. Just a heads up: I'm going to squash into a single commit before merging but will not change the content.

tseaver commented Feb 15, 2016

Copy link
Copy Markdown
Contributor

SGTM

Also
- Adding pylint config to allow more lines in test modules.
- Making small docstring change to HappyBase connection
dhermes force-pushed the bigtable-row-commit branch from 321435e to 64b8ef0 Compare February 15, 2016 22:08
dhermes added a commit that referenced this pull request Feb 15, 2016
Implementing Row.commit() in Bigtable.
dhermes merged commit 9e08e57 into googleapis:master Feb 15, 2016
dhermes deleted the bigtable-row-commit branch February 15, 2016 22:08
parthea added a commit that referenced this pull request Nov 24, 2025
* fix: drop pkg_resources

* fix typo
parthea pushed a commit that referenced this pull request Nov 26, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Mar 6, 2026
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
* samples: Add samples for async download files #1470

* Add argument description for `async_download_blobs` function.

Co-authored-by: cojenco <cathyo@google.com>

* Addressed comments from cojenco@

* change download_as_string to bytes

* Don't print blob contents after downloading

* remove Google Inc , add Google LLC

* pass list of file_names as one of the params.

* fix lint issues

* fix whitespace lints

* remove unused variable i

---------

Co-authored-by: cojenco <cathyo@google.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
***Handle errors during stream restart in snapshot***

**Root Cause**
When `_restart_on_unavailable` caught a `ServiceUnavailable` or
resumable `InternalServerError`, it attempted to re-initialize the
iterator immediately within the `except` block. If this
re-initialization failed (e.g. due to a persistent transient error), the
exception would propagate unhandled, breaking the retry loop.

**Fix**
This change modifies the logic to reset the iterator to `None` and
`continue` the loop, forcing the re-initialization to occur inside the
`try` block. This ensures that subsequent errors during restart are
properly caught and retried.

**Testing**
Added unit tests to cover this specific behavior
parthea pushed a commit that referenced this pull request Mar 9, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v1.0.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
<details><summary>google-cloud-spanner: 3.62.0</summary>

##
[3.62.0](googleapis/python-spanner@v3.61.0...v3.62.0)
(2026-01-14)

### Features

* add uuid support (#1310)
([3b1792aa](googleapis/python-spanner@3b1792aa))

### Bug Fixes

* transaction_tag should be set on BeginTransactionRequest (#1463)
([3d3cea0b](googleapis/python-spanner@3d3cea0b))

* resolve pre-release dependency failures and sqlparse recursion (#1472)
([9ec95b7d](googleapis/python-spanner@9ec95b7d))

* handle errors during stream restart in snapshot (#1471)
([c0668735](googleapis/python-spanner@c0668735))

</details>
parthea pushed a commit that referenced this pull request Apr 1, 2026
…nce()` (#1471)

* feat: add GeoSeries.difference()

* add st_difference method and test cases for geo.difference and st_difference

* update method and tests

* update method and tests

* update test to cover different inputs

* update test assertion

* update testing with single geometry object and add notebook tag to ignore the exception

* fix docstrings

* modify geo_difference to make it available for use and update tests and notebook

* fix my py type error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL