FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adding Bigtable Cell class. by dhermes · Pull Request #1473 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Adding Bigtable Cell class. - #1473

Merged
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:bigtable-cell
Feb 16, 2016
ConversationCommits (2)ChecksFiles changed
Merged

Adding Bigtable Cell class.#1473
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:bigtable-cell

Conversation

dhermes commented Feb 15, 2016

Copy link
Copy Markdown
Contributor

Used to hold data in rows retrieved.

@tseaver This module could definitely use some design review (none of the content here yet, but worth discussing now or at least thinking about).

Right now, the implementation is as follows:

  • Rows are read from a Table (and a Cell is like a "column" in a row, so there can be many), so the helpers needed to parse a row that was read are in row_data.py
  • Mutations (in rows) are created directly on a Row, and this is all done in row.py (all code submitted or merged)

Adding Bigtable Cell class.
073131f 
Used to held data in rows retrieved.
dhermes added the api: bigtable Issues related to the Bigtable API. label Feb 15, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2016

tseaver commented Feb 16, 2016

Copy link
Copy Markdown
Contributor

Travis failed on the docs build:

Found undocumented public modules:

- gcloud.bigtable.row_data

ERROR: InvocationError: '/home/travis/build/GoogleCloudPlatform/gcloud-python/.tox/docs/bin/python /home/travis/build/GoogleCloudPlatform/gcloud-python/scripts/verify_included_modules.py'

tseaver commented Feb 16, 2016

Copy link
Copy Markdown
Contributor

No explicit tests for the Cell class' methods?

dhermes commented Feb 16, 2016

Copy link
Copy Markdown
Contributor Author

Double fail. Sorry, forgot to stage it. Must've been in a hurry.

dhermes commented Feb 16, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver PTAL.

Still would like to know what you think about having row.py and row_data.py separately.

tseaver commented Feb 16, 2016

Copy link
Copy Markdown
Contributor

Still would like to know what you think about having row.py and row_data.py separately.

My only quibble is with the filename: given that the module just contains the Cell class, ISTM that it would most logically be named gcloud.bigtable.cell.

dhermes commented Feb 16, 2016

Copy link
Copy Markdown
Contributor Author

Cell is just the beginning:
https://github.com/dhermes/gcloud-python-bigtable/blob/master/gcloud_bigtable/row_data.py

tseaver commented Feb 16, 2016

Copy link
Copy Markdown
Contributor

Cell is just the beginning:

SGTM

dhermes commented Feb 16, 2016

Copy link
Copy Markdown
Contributor Author

And the content of this commit?

tseaver commented Feb 16, 2016

Copy link
Copy Markdown
Contributor

Fine to merge.

dhermes added a commit that referenced this pull request Feb 16, 2016
Merge pull request #1473 from dhermes/bigtable-cell
180db64 
Adding Bigtable Cell class.
dhermes merged commit 180db64 into googleapis:master Feb 16, 2016
dhermes deleted the bigtable-cell branch February 16, 2016 01:56
dhermes mentioned this pull request Feb 17, 2016
Merged
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore(main): release 1.5.0 (#1473)
d2f4adf 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
fix: Change log level to debug for return_none_for_not_found_error (#…
8d0fcad 
…1473)
parthea pushed a commit that referenced this pull request Mar 9, 2026
docs(spanner): snippet for setting read lock mode (#1473)
2453e07 
Snippet shows how to set the read lock mode at the client-level and how
to override the option at the transaction-level.
parthea pushed a commit that referenced this pull request Mar 9, 2026
chore: librarian release pull request: 20260213T101303Z (#1497)
d4cee61 
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v1.0.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
<details><summary>google-cloud-spanner: 3.63.0</summary>

##
[3.63.0](googleapis/python-spanner@v3.62.0...v3.63.0)
(2026-02-13)

### Features

* add requestID info in error exceptions (#1415)
([2c5eb96c](googleapis/python-spanner@2c5eb96c))

### Bug Fixes

* prevent thread leak by ensuring singleton initialization (#1492)
([e792136a](googleapis/python-spanner@e792136a))

### Documentation

* snippet for setting read lock mode (#1473)
([7e79920c](googleapis/python-spanner@7e79920c))

</details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

tseaver

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL