Implementing HappyBase methods that aren't functional in Bigtable. - #1496
Conversation
Sorry, something went wrong.
|
Given the choice to have these stubs, LGTM. |
Sorry, something went wrong.
|
I'm not sure I understand. If the goal is swapping from happybase import foo for from gcloud.bigtable.happybase import foo, is there a better solution? (Honestly it's like pick your error, NotImplementedError or AttributeError or ...) |
Sorry, something went wrong.
|
I just meant that being able to import foo but not use it doesn't seem like much of a win: the user is going to need to change code (beyond the imports) either way. |
Sorry, something went wrong.
|
Yeah I agree. @jgeewax How do you think we should handle the methods in this PR? |
Sorry, something went wrong.
|
(Commenting from mobile, so forgive if this is answered elsewhere.) How much other code needs to change ? Any short example before and after snippets ? |
Sorry, something went wrong.
|
For context, if the method is just missing, people may go off the assumption that this just want implemented yet. Having this exception raised makes it clear that it wasn't as didn't do the work, it's that the concept doesn't make sense for Bigtable. |
Sorry, something went wrong.
|
For this particular PR it is essentially the choice between class A (@tseaver suggestion) or class B (current implementation of this PR): >>> class A(object):
... pass
...
>>> a = A()
>>> a.foo(1, 2)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: 'A' object has no attribute 'foo'
>>> class B(object):
... def foo(self, x, y):
... raise NotImplementedError('We cannot do', x, 'or', y)
...
>>> b = B()
>>> b.foo(1, 2)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "<stdin>", line 3, in foo
NotImplementedError: ('We cannot do', 1, 'or', 2) |
Sorry, something went wrong.
|
OK going to leave it as-is. |
Sorry, something went wrong.
Providing the methods for interface compatibility.
Implementing HappyBase methods that aren't functional in Bigtable.
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…entials (#1496) * feat: refactor AWS and identity pool credentials to use suppliers (#1484) * feat: refactor aws and identity pool credentials to use supplier framework * Linting * changing class types * linting * remove unused import * Fix typing * add docstring and fix casing * feat: Adds support for custom suppliers in AWS and Identity Pool credential instantiation (#1494) * feat: refactor aws and identity pool credentials to use supplier framework * Linting * changing class types * linting * remove unused import * Fix typing * add docstring and fix casing * feat: adds support for passing suppliers to credentials. * fixes merge issues and adds _has_custom_supplier method * adds _has_custom_supplier function to identity_pool * Update google/auth/external_account.py Co-authored-by: Carl Lundin <108372512+clundin25@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Carl Lundin <108372512+clundin25@users.noreply.github.com> * Respond to comments and fix docs --------- Co-authored-by: Carl Lundin <108372512+clundin25@users.noreply.github.com> * docs: add documentation for suppliers (#1495) * docs: update docs for programmatic * add space * update user guide * update docs * Apply suggestions from code review Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com> * Update docs * Add docs about context and request --------- Co-authored-by: Carl Lundin <108372512+clundin25@users.noreply.github.com> Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>
Providing the methods for interface compatibility.