Implementing HappyBase Table atomic counter helpers. by dhermes · Pull Request #1514 · googleapis/google-cloud-python · GitHub

No description provided.

@jgeewax HappyBase also has a counter_set but as of now, I have made it NotImplemented because Bigtable doesn't have a way to make it atomic. WDYT is the right move here? I did make a note in the docstring of counter_get that

.. note::

    Application code should **never** store a counter value directly;
    use the atomic :meth:`counter_inc` and :meth:`counter_dec` methods
    for that.

@dhermes, @jgeewax: I'm pretty much offline until Thursday, 2016-02-25 (in Palo Alto teaching a course). Likewise for #1515, #1516, #1502, #1512, and #1513.

This LGTM, although from a readability nit standpoint counter_inc is a little hard to follow at first glance. I'm unsure why.

RE: "Hard to follow." That's the kind of feedback I was hoping to surface (by breaking into small PRs). Do you think the low-level row should handle more of the responsibilities? Do you think the method should use a helper? etc.

Perhaps just some comments in-line. Poor example, but what is bytes_value = column_cells[0][0] doing exactly? Why [0][0]?

(this also just may be my unfamiliarity with bigtable showing)

I don't think it's your unfamiliarity, but that also is good in that you don't have a bias towards how things should be. I had to look up what [0][0] is for: Row.commit_modifications returns a dictionary keyed by column families. Each column family contains a dictionary keys by column names (within the family). Each column has a list of tuples. Each tuple is a pair of the bytes in the cell and the associated timestamp. It's enough to need a breather after the explanation.

Wow, that is a lot to explain.

Luckily the docstring proves that a picture is worth a thousand words:

{
    u'col-fam-id': {
        b'col-name1': [
            (b'cell-val', datetime.datetime(...)),
            (b'cell-val-newer', datetime.datetime(...)),
        ],
        b'col-name2': [
            (b'altcol-cell-val', datetime.datetime(...)),
        ],
    },
    u'col-fam-id2': {
        b'col-name3-but-other-fam': [
            (b'foo', datetime.datetime(...)),
        ],
    },
}

Ah, very helpful. Can you include a comment that notes the expected format of the column_cells object?

@jonparrott PTAL

LGTM, please squash commits.

Implementing HappyBase Table atomic counter helpers.

* fix: makes default token_url universe aware * fix defaulting

#1541) * bug: fixes discrepancy btwn python-api-core & bigquery re object default timeout * Fix: loosen ipywidget dependency (#1504) * fix: updates ipywidget dependency * fix: updates ipywidget version number * chore(main): release 3.6.0 (#1490) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * docs: Remove < 3.11 reference from README (#1502) * chore(python): upgrade gcp-releasetool in .kokoro [autoapprove] (#1508) Source-Link: googleapis/synthtool@5f2a608 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * feat: add `connection_properties` and `create_session` to `LoadJobConfig` (#1509) * feat: added `connection_properties` and `create_session` in load job * chore(deps): update all dependencies (#1501) * chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(deps): update all dependencies (#1513) * feat: add default_query_job_config property and property setter to BQ client (#1511) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [feature request](https://togithub.com/googleapis/python-bigquery/issues/1512) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes - [feature request](https://togithub.com/googleapis/python-bigquery/issues/1512)🦕 - [internal bug](https://b.corp.google.com/issues/271044948) * chore(deps): update all dependencies (#1514) * chore(deps): update dependency charset-normalizer to v3.1.0 (#1518) * chore(main): release 3.7.0 (#1507) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * feat: expose configuration property on CopyJob, ExtractJob, LoadJob, QueryJob (#1521) * feat: expose configuration property on CopyJob, ExtractJob, LoadJob, QueryJob Note for google-cloud-bigquery developers: This also refactors these classes so that `_set_properties` does not modify the `_properties` dictionary in-place. Doing so was also mutating the request object, making it difficult to debug what request was _actually_ sent. Before this change, many tests hallucinated that the request was always equal to the response. * E google.api_core.exceptions.BadRequest: 400 Clone operation with write disposition WRITE_TRUNCATE is not supported. Please try again with WRITE_EMPTY. * chore(deps): Update nox in .kokoro/requirements.in [autoapprove] (#1527) Source-Link: googleapis/synthtool@92006bb Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * feat: add default LoadJobConfig to Client (#1526) * feat: add bool, int, float, string dtype to to_dataframe (#1529) * fix: loosen ipywidgets restrictions further to address ipython compatibility issues (#1531) * fix: loosen ipywidgets restrictions further to address ipython compatibility issues * include ipywidgets in prerelease deps * show all package versions * add ipykernel dependency * ipykernel in noxfile * oops * chore(main): release 3.8.0 (#1525) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * fix: keyerror when the load_table_from_dataframe accesses a unmapped dtype dataframe index (#1535) * feat: expose query job on dbapi cursor (#1520) Co-authored-by: Tim Swast <swast@google.com> * chore(main): release 3.9.0 (#1537) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: update tests to be compatible with pandas 2.0 (#1538) * chore: update tests to be compatible with pandas 2.0 * use StringDtype without storage argument * avoid Float64Dtype on older pandas * chore(deps): update all dependencies (#1522) * chore: updates minimum version of bqstorage (#1542) * chore: updates minimum version of bqstorage * removes unneeded test * updates linting, removes unneeded comment * updates conditional checks, comments, adds test * Removes test, adds pragma no cover * Removes test * fix linting error --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Atsushi Yamamoto <yamaatsushi927@gmail.com> Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Shobhit Singh <just.shobhit@gmail.com> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: chelsea-lin <124939984+chelsea-lin@users.noreply.github.com> Co-authored-by: Tim Swast <swast@google.com> Co-authored-by: r1b <robert.cole.jensen@gmail.com>

dhermes added the api: bigtable Issues related to the Bigtable API. label Feb 21, 2016

dhermes assigned tseaver Feb 21, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2016

dhermes reviewed Feb 21, 2016
View reviewed changes

dhermes assigned theacodes and unassigned tseaver Feb 22, 2016

dhermes reviewed Feb 23, 2016
View reviewed changes

dhermes force-pushed the happybase-atomic-counter branch from 62b8e75 to 1285aa3 Compare February 24, 2016 16:23

Implementing HappyBase Table atomic counter helpers.

bb49935

dhermes force-pushed the happybase-atomic-counter branch from 1285aa3 to bb49935 Compare February 24, 2016 17:38

dhermes added a commit that referenced this pull request Feb 24, 2016

Merge pull request #1514 from dhermes/happybase-atomic-counter

983d0ee

Implementing HappyBase Table atomic counter helpers.

dhermes merged commit 983d0ee into googleapis:master Feb 24, 2016

dhermes deleted the happybase-atomic-counter branch February 24, 2016 17:43

theacodes mentioned this pull request Mar 4, 2016

Upgrading version to 0.11.0 #1573

Merged

parthea pushed a commit that referenced this pull request Nov 26, 2025

fix: makes default token_url universe aware (#1514 )

33e8af3

* fix: makes default token_url universe aware * fix defaulting

parthea pushed a commit that referenced this pull request Mar 6, 2026

chore(deps): update all dependencies (#1514 )

182e216

+                      """
+                      row = self._low_level_table.row(row)
+                      if isinstance(column, six.binary_type):
+                          column = column.decode('utf-8')

+                      column_cells = modified_cells[column_family_id][column_qualifier]
+                      if len(column_cells) != 1:
+                          raise ValueError('Expected server to return one modified cell.')
+                      bytes_value = column_cells[0][0]

Implementing HappyBase Table atomic counter helpers. by dhermes · Pull Request #1514 · googleapis/google-cloud-python · GitHub

Uh oh!

Implementing HappyBase Table atomic counter helpers. - #1514

Implementing HappyBase Table atomic counter helpers.#1514dhermes merged 1 commit intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom dhermes:happybase-atomic-counterdhermes/google-cloud-python:happybase-atomic-counterCopy head branch name to clipboard

Conversation

dhermes commented Feb 21, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Feb 21, 2016

Uh oh!

tseaver commented Feb 22, 2016

Uh oh!

theacodes commented Feb 23, 2016

Uh oh!

dhermes commented Feb 23, 2016

Uh oh!

theacodes commented Feb 23, 2016

Uh oh!

theacodes commented Feb 23, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Feb 23, 2016

Uh oh!

theacodes commented Feb 23, 2016

Uh oh!

dhermes commented Feb 23, 2016

Uh oh!

theacodes commented Feb 23, 2016

Uh oh!

dhermes commented Feb 24, 2016

Uh oh!

theacodes commented Feb 24, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Implementing HappyBase Table atomic counter helpers.#1514
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:happybase-atomic-counter