tests: add mypy presubmit check - #15457
Merged
parthea merged 1 commit intoJan 30, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Sorry, something went wrong.
parthea
force-pushed
the
add-my-presubmit
branch
from
39e9282 to
c11b47e
Compare
January 14, 2026 18:11
parthea
force-pushed
the
add-my-presubmit
branch
from
c11b47e to
ef73566
Compare
January 23, 2026 17:57
Merged
parthea
added a commit
that referenced
this pull request
Jan 23, 2026
Towards #15104 This is needed to unblock #15457 which has the following mypy failure for `google-cloud-automl` ``` nox > mypy -p google .nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/automl_v1beta1/services/tables/gcs_client.py:25: error: Library stubs not installed for "pandas" [import-untyped] .nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/automl_v1beta1/services/tables/gcs_client.py:25: note: Hint: "python3 -m pip install pandas-stubs" .nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/automl_v1beta1/services/tables/gcs_client.py:25: note: (or run "mypy --install-types" to install all missing stub packages) .nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/automl_v1beta1/services/tables/gcs_client.py:25: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports .nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/automl_v1beta1/services/tables/gcs_client.py:30: error: Module "google.cloud" has no attribute "storage" [attr-defined] ``` See follow up bug for`google-cloud-storage` : https://github.com/googleapis/python-storage/issues/318 See follow up bug for pre-release failure: googleapis/proto-plus-python#558 See follow up bug to add `--strict` flag for mypy: https://github.com/googleapis/gapic-generator-python/issues/2089 --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
parthea
added a commit
that referenced
this pull request
Jan 30, 2026
…itoring (#15493) Towards #15104 This is needed to unblock #15457 . See the following mypy failure for `google-cloud-monitoring-dashboards` See follow up issue #11858 to remove the `google/monitoring` folder which is no longer being generated automatically. See follow up issue googleapis/proto-plus-python#558 for the `prerelease` presubmit failure. ``` .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/types/service.py:19: error: Name "proto" is not defined [name-defined] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/types/drilldowns.py:19: error: Name "proto" is not defined [name-defined] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/base.py:49: error: Incompatible default for argument "credentials" (default has type "None", argument has type "Credentials") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/base.py:49: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/base.py:49: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:52: error: Incompatible default for argument "credentials" (default has type "None", argument has type "Credentials") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:52: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:52: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:53: error: Incompatible default for argument "credentials_file" (default has type "None", argument has type "str") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:53: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:53: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:54: error: Incompatible default for argument "scopes" (default has type "None", argument has type "Sequence[str]") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:54: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:54: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:56: error: Incompatible default for argument "api_mtls_endpoint" (default has type "None", argument has type "str") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:56: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:56: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:57: error: Incompatible default for argument "client_cert_source" (default has type "None", argument has type "Callable[[], tuple[bytes, bytes]]") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:57: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:57: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:97: error: Incompatible types in assignment (expression has type "bool", variable has type "Credentials") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:115: error: Function "client_cert_source" could always be true in boolean context [truthy-function] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:148: error: Incompatible default for argument "credentials" (default has type "None", argument has type "Credentials") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:148: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:148: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:149: error: Incompatible default for argument "credentials_file" (default has type "None", argument has type "str") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:149: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:149: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:54: error: Incompatible default for argument "credentials" (default has type "None", argument has type "Credentials") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:54: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:54: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:95: error: Incompatible default for argument "credentials" (default has type "None", argument has type "Credentials") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:95: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:95: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:99: error: Incompatible default for argument "api_mtls_endpoint" (default has type "None", argument has type "str") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:99: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:99: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/client.py:474: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:55: error: Argument 1 to "get_transport_class" of "DashboardsServiceClientMeta" has incompatible type "type[type[DashboardsServiceClient]]"; expected "DashboardsServiceClientMeta" [arg-type] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:61: error: Incompatible default for argument "credentials" (default has type "None", argument has type "Credentials") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:61: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:61: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:63: error: Module "google.api_core.client_options" is not valid as a type [valid-type] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:63: note: Perhaps you meant to use a protocol matching the module structure? .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:103: error: Incompatible default for argument "request" (default has type "None", argument has type "CreateDashboardRequest") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:103: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:103: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:105: error: Incompatible default for argument "retry" (default has type "_MethodDefault", argument has type "Retry") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:106: error: Incompatible default for argument "timeout" (default has type "None", argument has type "float") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:106: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:106: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:164: error: Incompatible default for argument "request" (default has type "None", argument has type "ListDashboardsRequest") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:164: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:164: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:166: error: Incompatible default for argument "retry" (default has type "_MethodDefault", argument has type "Retry") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:167: error: Incompatible default for argument "timeout" (default has type "None", argument has type "float") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:167: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:167: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:234: error: Incompatible default for argument "request" (default has type "None", argument has type "GetDashboardRequest") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:234: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:234: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:236: error: Incompatible default for argument "retry" (default has type "_MethodDefault", argument has type "Retry") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:237: error: Incompatible default for argument "timeout" (default has type "None", argument has type "float") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:237: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:237: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:295: error: Incompatible default for argument "request" (default has type "None", argument has type "DeleteDashboardRequest") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:295: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:295: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:297: error: Incompatible default for argument "retry" (default has type "_MethodDefault", argument has type "Retry") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:298: error: Incompatible default for argument "timeout" (default has type "None", argument has type "float") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:298: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:298: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:345: error: Incompatible default for argument "request" (default has type "None", argument has type "UpdateDashboardRequest") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:345: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:345: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:347: error: Incompatible default for argument "retry" (default has type "_MethodDefault", argument has type "Retry") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:348: error: Incompatible default for argument "timeout" (default has type "None", argument has type "float") [assignment] .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:348: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True .nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:348: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase ```
Merged
parthea
added a commit
that referenced
this pull request
Jan 30, 2026
Towards #15104 This is needed to unblock #15457 . See follow up issue googleapis/proto-plus-python#558 for the `prerelease` presubmit failure. See the following mypy failure for `google-cloud-monitoring` ``` 2026-01-16T21:21:02.1088102Z nox > Running session mypy-3.14 2026-01-16T21:21:02.1093302Z nox > Creating virtual environment (virtualenv) using python3.14 in .nox/mypy-3-14 2026-01-16T21:21:02.3445193Z nox > python -m pip install 'mypy<1.16.0' types-requests types-protobuf 2026-01-16T21:21:05.5617360Z nox > python -m pip install . 2026-01-16T21:21:10.8264379Z nox > mypy -p google 2026-01-16T21:21:26.4063416Z .nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/monitoring_v3/__init__.py:232: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] 2026-01-16T21:21:26.4393843Z .nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/monitoring_v3/_dataframe.py:20: error: Library stubs not installed for "pandas" [import-untyped] 2026-01-16T21:21:26.4396224Z .nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/monitoring_v3/_dataframe.py:20: note: Hint: "python3 -m pip install pandas-stubs" 2026-01-16T21:21:26.4398337Z .nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/monitoring_v3/_dataframe.py:20: note: (or run "mypy --install-types" to install all missing stub packages) 2026-01-16T21:21:26.4400993Z .nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/monitoring_v3/_dataframe.py:20: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports ``` See the following mypy failure for `google-cloud-org-policy` ``` 2026-01-16T21:25:54.1998139Z nox > Running session mypy-3.14 2026-01-16T21:25:54.2002997Z nox > Creating virtual environment (virtualenv) using python3.14 in .nox/mypy-3-14 2026-01-16T21:25:54.4531153Z nox > python -m pip install 'mypy<1.16.0' types-requests types-protobuf 2026-01-16T21:25:57.9686970Z nox > python -m pip install . 2026-01-16T21:26:03.3150701Z nox > mypy -p google 2026-01-16T21:26:13.7960116Z .nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/orgpolicy/v1/__init__.py:26: error: Need type annotation for "names" (hint: "names: list[<type>] = ...") [var-annotated] ``` See the following mypy failure for `google-cloud-speech` ``` .nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/speech_v1p1beta1/__init__.py:131: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] .nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/speech_v1p1beta1/__init__.py:172: error: Name "SpeechClient" already defined (possibly by an import) [no-redef] .nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/speech_v1p1beta1/__init__.py:172: error: Definition of "streaming_recognize" in base class "SpeechHelpers" is incompatible with definition in base class "SpeechClient" [misc] ``` See the following failure for `google-cloud-vision` ``` 2026-01-16T21:48:11.3461545Z nox > mypy -p google 2026-01-16T21:48:23.0397649Z google/cloud/vision_helpers/__init__.py:18: error: Skipping analyzing "proto": module is installed, but missing library stubs or py.typed marker [import-untyped] 2026-01-16T21:48:23.0399910Z google/cloud/vision_helpers/__init__.py:18: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports ```
Merged
parthea
force-pushed
the
add-my-presubmit
branch
from
07a0a64 to
1df5eaf
Compare
January 30, 2026 19:57
parthea
marked this pull request as ready for review
January 30, 2026 19:58
parthea
force-pushed
the
add-my-presubmit
branch
from
1df5eaf to
923812a
Compare
January 30, 2026 19:58
daniel-sanche
approved these changes
Jan 30, 2026
parthea
added a commit
that referenced
this pull request
Jan 30, 2026
Towards #15104 This is needed to unblock #15457 . See follow up issue googleapis/proto-plus-python#558 for the `prerelease` presubmit failure. See the following mypy failure for `grafeas` ``` 2026-01-16T22:02:28.7158467Z grafeas/grafeas_v1/services/grafeas/client.py:362: error: Incompatible default for argument "transport" (default has type "None", argument has type "str | GrafeasTransport") ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15104