| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@jgeewax @jonparrott LMK what you guys think of this |
Sorry, something went wrong.
|
This seems pretty reasonable in terms of the API surface/usage. |
Sorry, something went wrong.
|
👍 |
Sorry, something went wrong.
|
I think I should update bigtable-data-api.rst as well |
Sorry, something went wrong.
|
Now that I see the change, it feels like there should really be two different row classes in play, rather than having methods which are present, but only available based on the value of append. |
Sorry, something went wrong.
I'm somewhat leaning towards this as well. Row seems to have significant variadic behavior based on one argument. |
Sorry, something went wrong.
|
Two classes or three? There are three distinct cases here. Also, do users want three? The worst / grossest "variadic"-ness to me is in the output of commit(). |
Sorry, something went wrong.
|
@tseaver @jonparrott Bump (want to get a release out ASAP so this PR can't block too long). Two questions:
Also @jgeewax Please weigh in. |
Sorry, something went wrong.
|
Three classes, I think: the Table.row() factory could figure out which one to instantiate, based on the params passed? |
Sorry, something went wrong.
Agreed. |
Sorry, something went wrong.
|
Working on it now. |
Sorry, something went wrong.
|
This can definitely be dropped since #1557 and others covered it. |
Sorry, something went wrong.
feat(zb-experimental): Add AsyncMultiRangeDownloader and it's init method.
* feat: support bq connection path format For example, now a user specified bq connection like "projects/project_id/locations/northamerica-northeast1/connections/conn-name" would also be supported. * include path format in tests with connection mismatch * pass cloud_function_service_account="default" in more tests
| Back | FazBrowse Home | New Git URL |
Fixes #1548.