| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Would it make sense to make this an extra? |
Sorry, something went wrong.
|
I like the idea of the extra: users can make perfectly valid use of gcloud without grpc. |
Sorry, something went wrong.
|
👍 I like the idea. Then we'd have pip install gcloud[grpc] for people that want to use gRPC? @jgeewax Please weigh in |
Sorry, something went wrong.
|
Actually I think it's better for the extra to the the part of this library that requires extra dependencies. So IMO it should be pip install gcloud[bigtable]. |
Sorry, something went wrong.
|
But in the not-too-distant future datastore, pubsub, logging, others? will have direct gRPC support in this library. |
Sorry, something went wrong.
|
Hmm. Fair point. I'm unsure. It seems that right now grpc doesn't have a good install story (unless that's recently changed). One part of me is leaning on having grpc remain an "extra" (in one way or another) until the install story improves or the tipping point where most clients in this library use grpc. @jgeewax what do you think? |
Sorry, something went wrong.
|
pip install grpcio>=0.13.0 works fairly well now, but must be 2.7 and only targets a limited number of platforms (but Linux, OS X and Windows covers a lot). |
Sorry, something went wrong.
|
That's fair, I suppose. Are any os-level dependencies needed other than just build-essential? |
Sorry, something went wrong.
|
No idea. @nathanielmanistaatgoogle do you know who might be able to chime in? |
Sorry, something went wrong.
|
I don't think even build-essential is needed.... It shouldn't as there's no compiling so gcc and make shouldn't be required for this... |
Sorry, something went wrong.
|
Cool, SGTM. |
Sorry, something went wrong.
|
I'm about to test it on bare GCE Debian and Ubuntu images. |
Sorry, something went wrong.
|
Seems to work on Ubuntu: $ sudo apt-get update
$ sudo apt-get -y upgrade
$ curl -O https://bootstrap.pypa.io/get-pip.py
$ sudo python get-pip.py
$ sudo -H pip install --upgrade pip
$ sudo -H pip install 'grpcio==0.13.0'
# FAILURE: https://gist.github.com/dhermes/f3cc291bb289ae69c86d
$ sudo -H pip install --upgrade six
$ sudo -H pip install 'grpcio==0.13.0'
$ # SUCCESS!
$ dpkg -s build-essential
dpkg-query: package 'build-essential' is not installed and no information is available
Use dpkg --info (= dpkg-deb --info) to examine archive files,
and dpkg --contents (= dpkg-deb --contents) to list their contents. |
Sorry, something went wrong.
|
Confirmed it works (with the same funky VersionConflict when --upgrade isn't used) on Debian |
Sorry, something went wrong.
grpcio can only be installed with Python 2.7, so the py27 tox environment is the only one that doesn't need to run without mocks.
| python2.7 | ||
| deps = | ||
| {[testenv]deps} | ||
| grpcio >= 0.13.0 |
|
@tseaver PTAL. Updated to make it an extra. |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
Adding grpcio to setup.py as an extra.
|
grpc 0.13.0 is broken on UCS2 versions of python 2.7 (which you get when you build Python 2.x from source). We should drop testing with it in tox until they make a release with the fix. |
Sorry, something went wrong.
|
@tseaver can you file an issue? I'm AFK right now |
Sorry, something went wrong.
Sorry, something went wrong.
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* hotfix: handle case when expirationMs is None * Add test for unsetting table exp * Update tests/unit/test_table.py * Update exp_resource for the unsetting_exp test --------- Co-authored-by: Tim Swast <swast@google.com>
* refactor: change window package to module to simplify code structure * move Window to window/rolling.py to mimic pandas structure
| Back | FazBrowse Home | New Git URL |
grpcio can only be installed with Python 2.7, so the py27 tox environment is the only one that doesn't need to run without mocks.
FYI @jgeewax the grpcio install fails on Python 2.6 and 3.4 (didn't try 3.5).