chore: librarian onboard pull request: 20260224T120346Z - #15607
Merged
parthea merged 1 commit intoFeb 25, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the onboarding of the google-cloud-workloadmanager Python client library. It integrates the new library into the repository's build and documentation systems, providing a fully functional client for the Workload Manager API. The changes are entirely generated, ensuring consistency and adherence to standard library practices. Highlights
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here. Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Sorry, something went wrong.
parthea
approved these changes
Feb 24, 2026
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code Review
This pull request onboards the new google-cloud-workloadmanager client library. The changes are extensive and mostly consist of auto-generated boilerplate code, including the client library source, documentation, samples, and configuration files. My review focused on identifying potential issues that might have been missed by the generation process. I found a documentation issue in a docstring regarding cron schedule examples which could be misleading to users. Otherwise, the onboarding seems to be in good shape.
Sorry, something went wrong.
Comment thread
packages/google-cloud-workloadmanager/google/cloud/workloadmanager_v1/types/service.py
Comment on lines
+102
to
+103
| - ``0 0 */7 * *`` # Weekly | ||
| - ``0 0 */14 * *`` # Every 14 days |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The cron expressions for "Weekly" and "Every 14 days" in the comment for the schedule field appear to be incorrect or misleading.
- The expression 0 0 */7 * * is described as "Weekly", but it will run at 00:00 on every 7th day of the month (e.g., day 1, 8, 15, 22, 29). A standard weekly cron schedule would use the day-of-week field (e.g., 0 0 * * 0 for every Sunday).
- Similarly, 0 0 */14 * * is described as "Every 14 days", but it will run on the 1st, 15th, and 29th of the month.
This could confuse users trying to set up scheduled evaluations. Please verify if these are the intended schedules and update the comments for clarity.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR created by the Librarian CLI to onboard a new Cloud Client Library.
BEGIN_COMMIT
feat: onboard a new library
PiperOrigin-RevId: 869327994
Library-IDs: google-cloud-workloadmanager
END_COMMIT
Librarian Version: v0.8.3
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c