Add 'Logger.log_text' method. - #1567
Merged
tseaver merged 1 commit intoMar 9, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Comment thread
gcloud/logging/logger.py
| """Fully-qualified name used in logging APIs""" | ||
| return 'projects/%s/logs/%s' % (self.project, self.name) | ||
|
|
||
| def _require_client(self, client): |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
Done with review. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Is that an LGTM? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Nope |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
What issue remains, besides _require_client, which we use all over the place? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
$ git grep -l _require_client
gcloud/bigquery/dataset.py
gcloud/bigquery/job.py
gcloud/bigquery/query.py
gcloud/bigquery/table.py
gcloud/dns/changes.py
gcloud/dns/zone.py
gcloud/pubsub/subscription.py
gcloud/pubsub/topic.py
gcloud/resource_manager/project.py
gcloud/search/document.py
gcloud/storage/_helpers.py
gcloud/storage/acl.py
gcloud/storage/blob.py
gcloud/storage/bucket.py |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM. Sorry for the hold up, I was very distracted at that moment so didn't want to jump the gun. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
No worries! |
Sorry, something went wrong.
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
…orm/python-docs-samples#1567) * Added the sample for Word Level Confidence * Added the extra line * Added parameter comment * Removed the line with blank space
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
…orm/python-docs-samples#1567) * Added the sample for Word Level Confidence * Added the extra line * Added parameter comment * Removed the line with blank space
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
…orm/python-docs-samples#1567) * Added the sample for Word Level Confidence * Added the extra line * Added parameter comment * Removed the line with blank space
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
…orm/python-docs-samples#1567) * Added the sample for Word Level Confidence * Added the extra line * Added parameter comment * Removed the line with blank space
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209 <details><summary>google-cloud-pubsub: 2.34.0</summary> ## [2.34.0](googleapis/python-pubsub@v2.33.0...v2.34.0) (2025-12-16) ### Features * support mTLS certificates when available (#1566) ([24761a2f](googleapis/python-pubsub@24761a2f)) </details>
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
* fix: filter None values from OpenTelemetry attributes * moved filtering out before return value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't yet expose any of the optional parameters (see #1566).