chore: librarian generate pull request: 20260305T173911Z - #16034
Merged
parthea merged 1 commit intoMar 5, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Google Cloud Compute Engine v1 API client library. It primarily introduces two new services, RegionHealthAggregationPolicies and ReservationSlots, along with their associated clients, types, and documentation. Additionally, it incorporates various API enhancements, including new parameters for several existing resources and clarifications in client method descriptions. These changes reflect an update to the underlying Compute Engine v1 API to revision 20260213. Highlights
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here. Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code Review
This pull request, generated by the Librarian CLI, updates the Compute Engine v1 API. It introduces new services such as RegionHealthAggregationPolicies and ReservationSlots, along with numerous updates to existing types, methods, and documentation. The changes are extensive and primarily auto-generated. My review identified several instances of broken docstring formatting that impact readability, and I have provided suggestions to correct them. These comments align with the provided rules, as the rules do not cover docstring formatting. Beyond these formatting issues, the generated code appears to be in order.
Sorry, something went wrong.
Comment thread
...ogle-cloud-compute/google/cloud/compute_v1/services/global_network_endpoint_groups/client.py
Comment on lines
+1721
to
+1738
| Note: Use the following APIs to manage | ||
| network endpoint groups: | ||
|
|
||
| - | ||
| To manage NEGs with zonal scope (such | ||
| as zonal NEGs, hybrid connectivity | ||
| NEGs): zonal | ||
| API | ||
| - | ||
| To manage NEGs with regional scope | ||
| (such as regional internet NEGs, | ||
| serverless NEGs, Private Service Connect | ||
| NEGs): regional API | ||
| - | ||
| To manage NEGs with global scope | ||
| (such as global internet NEGs):global | ||
| API | ||
|
|
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The formatting of this note is broken, with incorrect indentation and line breaks, making it difficult to read. It should be formatted as a proper list for clarity. This formatting issue is repeated in other docstrings in this and other related files.
Suggested change
| Note: Use the following APIs to manage | |
| network endpoint groups: | |
| - | |
| To manage NEGs with zonal scope (such | |
| as zonal NEGs, hybrid connectivity | |
| NEGs): zonal | |
| API | |
| - | |
| To manage NEGs with regional scope | |
| (such as regional internet NEGs, | |
| serverless NEGs, Private Service Connect | |
| NEGs): regional API | |
| - | |
| To manage NEGs with global scope | |
| (such as global internet NEGs):global | |
| API | |
| Note: Use the following APIs to manage network endpoint groups: | |
| - **zonal API:** To manage NEGs with zonal scope (such as | |
| zonal NEGs, hybrid connectivity NEGs). | |
| - **regional API:** To manage NEGs with regional scope (such | |
| as regional internet NEGs, serverless NEGs, Private | |
| Service Connect NEGs). | |
| - **global API:** To manage NEGs with global scope (such as | |
| global internet NEGs). | |
Sorry, something went wrong.
Comment thread
...ages/google-cloud-compute/google/cloud/compute_v1/services/network_endpoint_groups/client.py
Comment on lines
+1926
to
+1943
| Note: Use the following APIs to manage | ||
| network endpoint groups: | ||
|
|
||
| - | ||
| To manage NEGs with zonal scope (such | ||
| as zonal NEGs, hybrid connectivity | ||
| NEGs): zonal | ||
| API | ||
| - | ||
| To manage NEGs with regional scope | ||
| (such as regional internet NEGs, | ||
| serverless NEGs, Private Service Connect | ||
| NEGs): regional API | ||
| - | ||
| To manage NEGs with global scope | ||
| (such as global internet NEGs):global | ||
| API | ||
|
|
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The formatting of this note is broken, with incorrect indentation and line breaks, making it difficult to read. It should be formatted as a proper list for clarity. This formatting issue is repeated in other docstrings in this and other related files.
Suggested change
| Note: Use the following APIs to manage | |
| network endpoint groups: | |
| - | |
| To manage NEGs with zonal scope (such | |
| as zonal NEGs, hybrid connectivity | |
| NEGs): zonal | |
| API | |
| - | |
| To manage NEGs with regional scope | |
| (such as regional internet NEGs, | |
| serverless NEGs, Private Service Connect | |
| NEGs): regional API | |
| - | |
| To manage NEGs with global scope | |
| (such as global internet NEGs):global | |
| API | |
| Note: Use the following APIs to manage network endpoint groups: | |
| - **zonal API:** To manage NEGs with zonal scope (such as | |
| zonal NEGs, hybrid connectivity NEGs). | |
| - **regional API:** To manage NEGs with regional scope (such | |
| as regional internet NEGs, serverless NEGs, Private | |
| Service Connect NEGs). | |
| - **global API:** To manage NEGs with global scope (such as | |
| global internet NEGs). | |
Sorry, something went wrong.
Comment thread
...ogle-cloud-compute/google/cloud/compute_v1/services/region_network_endpoint_groups/client.py
Comment on lines
+1816
to
+1833
| Note: Use the following APIs to manage | ||
| network endpoint groups: | ||
|
|
||
| - | ||
| To manage NEGs with zonal scope (such | ||
| as zonal NEGs, hybrid connectivity | ||
| NEGs): zonal | ||
| API | ||
| - | ||
| To manage NEGs with regional scope | ||
| (such as regional internet NEGs, | ||
| serverless NEGs, Private Service Connect | ||
| NEGs): regional API | ||
| - | ||
| To manage NEGs with global scope | ||
| (such as global internet NEGs):global | ||
| API | ||
|
|
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The formatting of this note is broken, with incorrect indentation and line breaks, making it difficult to read. It should be formatted as a proper list for clarity. This formatting issue is repeated in other docstrings in this and other related files.
Suggested change
| Note: Use the following APIs to manage | |
| network endpoint groups: | |
| - | |
| To manage NEGs with zonal scope (such | |
| as zonal NEGs, hybrid connectivity | |
| NEGs): zonal | |
| API | |
| - | |
| To manage NEGs with regional scope | |
| (such as regional internet NEGs, | |
| serverless NEGs, Private Service Connect | |
| NEGs): regional API | |
| - | |
| To manage NEGs with global scope | |
| (such as global internet NEGs):global | |
| API | |
| Note: Use the following APIs to manage network endpoint groups: | |
| - **zonal API:** To manage NEGs with zonal scope (such as | |
| zonal NEGs, hybrid connectivity NEGs). | |
| - **regional API:** To manage NEGs with regional scope (such | |
| as regional internet NEGs, serverless NEGs, Private | |
| Service Connect NEGs). | |
| - **global API:** To manage NEGs with global scope (such as | |
| global internet NEGs). | |
Sorry, something went wrong.
daniel-sanche
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: Update Compute Engine v1 API to revision 20260213
The breaking change exemption is approved in internal http://b/488396206
PiperOrigin-RevId:
Library-IDs: google-cloud-compute
Source-link: googleapis/googleapis@eb5a4e3f
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@69bf99a9
(exclusive) and
googleapis/googleapis@eb5a4e3f
(inclusive).
Librarian Version: v0.7.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c
Closes #16033