Add system test for 'logger.log_text' and 'logger.log_struct'. - #1609
Merged
tseaver merged 1 commit intoMar 17, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
system_tests/logging_.py
|
|
||
|
|
||
| def setUpModule(): | ||
| _helpers.PROJECT = TESTS_PROJECT |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
@dhermes any remaining issues? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Rebased after merging #1616 to the logging-api branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM. The eventual consistency hack might be easier to find if you factor it out into a helper (like is done in the bigtable test). |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
I've been thinking about a more generic retry wrapper (per #1619). |
Sorry, something went wrong.
tseaver
added a commit
that referenced
this pull request
Mar 17, 2016
Add system test for 'logger.log_text' and 'logger.log_struct'.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
…1609) * chore: add details for bigquery_connection in udf docstring * quick fix * Update bigframes/functions/_function_session.py Co-authored-by: Tim Sweña (Swast) <swast@google.com> * resolve the comments * sync the docstring --------- Co-authored-by: Tim Sweña (Swast) <swast@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.