Update logging codegen by geigerj · Pull Request #1629 · googleapis/google-cloud-python · GitHub

Reflects updates to the code generation made between January and now.

An sample usage snippet is available here: https://gist.github.com/geigerj/de050b53f8887e9d7a07

@geigerj thanks for the new PR! I'll skip the detail-oriented review since @dhermes is tackling that bit, but just wanted to let you know that looking at the generated wrappers for the protobuf/gRPC API is quite illuminating, as I'm working on the REST/JSON wrappers this month.

Design question. If the code is generated, couldn't you use the contents of the YAML file to just populate variables in the module? It seems that having to bear the weight of file I/O and parsing YAML is unneeded.

OK I finished my comments.

Design question. If the code is generated, couldn't you use the contents of the YAML file to just populate variables in the module? It seems that having to bear the weight of file I/O and parsing YAML is unneeded.

I feel the same way. There seems to be no real benefit to doing it this way.

Design question. If the code is generated, couldn't you use the contents of the YAML file to just populate variables in the module? It seems that having to bear the weight of file I/O and parsing YAML is unneeded.
I feel the same way. There seems to be no real benefit to doing it this way.

In the not too far-off future, the plan is to allow user configuration of api settings via yaml

the exact mechanism is still under discussion
hopefully, this will look a bit like application default creds, e.g,
- there is a yaml file in the package will contain fallback config values
- users will be specify an override either by specifying an environment variable or by copying to the settings to a well-known location

Update logging codegen

31fd1fc

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2016

dhermes reviewed Mar 18, 2016
View reviewed changes

This was referenced Mar 18, 2016

GitHub link in generated files should include SHA1 of commit googleapis/gax-python#55

Open

PathTemplate.instantiate should be renamed googleapis/gax-python#56

Closed

dhermes reviewed Mar 18, 2016
View reviewed changes

tbetbetbe mentioned this pull request Mar 18, 2016

Fix the comment describing the host name in the generated code googleapis/gax-python#57

Closed

dhermes reviewed Mar 18, 2016
View reviewed changes

tbetbetbe mentioned this pull request Mar 18, 2016

Fix dangling link comment in the service comment googleapis/gax-python#58

Closed

This was referenced Mar 18, 2016

Simplify the format string used to generate the custom tracking header googleapis/gax-python#59

Closed

Use {} rather than dict() googleapis/gax-python#60

Closed

               # EDITING INSTRUCTIONS
               # This file was generated from the file
-              # https://github.com/google/googleapis/blob/7710ead495227e80a0f06ceb66bdf3238d926f77/google/logging/v2/logging_config.proto,
+              # https://github.com/google/googleapis/blob/master/google/logging/v2/logging_config.proto,

+                      if app_name is None:
+                          app_name = 'gax'
+                      if app_version is None:
+                          app_version = google.gax.__version__

+                                 'https://www.googleapis.com/auth/logging.admin',
+                                 'https://www.googleapis.com/auth/logging.read',
+                                 'https://www.googleapis.com/auth/cloud-platform.read-only',
+                                 'https://www.googleapis.com/auth/cloud-platform', )

+                      google_apis_agent = '{}-{}/{}/gax-{}/{}'.format(
+                          app_name, app_version, self._CODE_GEN_NAME_VERSION,
+                          google.gax.__version__,
+                          'python-{}'.format(platform.python_version()))

Update logging codegen by geigerj · Pull Request #1629 · googleapis/google-cloud-python · GitHub

Uh oh!

Update logging codegen - #1629

Update logging codegen#1629geigerj wants to merge 3 commits intogoogleapis:grpc-logging-featuregoogleapis/google-cloud-python:grpc-logging-featurefrom geigerj:grpc-logging-featureCopy head branch name to clipboard

Conversation

geigerj commented Mar 17, 2016

Uh oh!

tbetbetbe commented Mar 17, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Mar 18, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Mar 18, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Mar 18, 2016

Uh oh!

theacodes commented Mar 18, 2016

Uh oh!

tbetbetbe commented Mar 18, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Update logging codegen#1629
geigerj wants to merge 3 commits into
googleapis:grpc-logging-featurefrom
geigerj:grpc-logging-feature