FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add 'Subscription.set_iam_policy' API wrapper. by tseaver · Pull Request #1645 · googleapis/google-cloud-python · GitHub

Add 'Subscription.set_iam_policy' API wrapper. - #1645

Merged
tseaver merged 4 commits into
googleapis:masterfrom
tseaver:pubsub-subscription-set_iam_policy
Mar 22, 2016
Merged

Add 'Subscription.set_iam_policy' API wrapper.#1645
tseaver merged 4 commits into
googleapis:masterfrom
tseaver:pubsub-subscription-set_iam_policy

Conversation

tseaver commented Mar 21, 2016

Copy link
Copy Markdown
Contributor

Uses #1644 as a base.

Toward #1073.

tseaver added the api: pubsub Issues related to the Pub/Sub API. label Mar 21, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 21, 2016

tseaver commented Mar 22, 2016

Copy link
Copy Markdown
Contributor Author

@dhermes Rebased after merging #1644 to master. PTAL

Comment thread docs/pubsub-usage.rst Outdated
>>> subscription = topic.subscription('subscription_name')
>>> policy = subscription.get_iam_policy() # API request
>>> policy.writers.add(policy.group('editors-list@example.com'))
>>> subscriptoin.set_iam_policy(policy) # API request

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Mar 22, 2016

Copy link
Copy Markdown
Contributor

LGTM other than a few small nits

tseaver added a commit that referenced this pull request Mar 22, 2016
tseaver merged commit efc1d41 into googleapis:master Mar 22, 2016
tseaver deleted the pubsub-subscription-set_iam_policy branch March 22, 2016 20:01
parthea pushed a commit that referenced this pull request Mar 6, 2026
* fix: relax timeout expectations

Changes to python-api-core can in certain cases cause timeout to be
represented as a literal python base object type.  This CL adjusts
logic that selects from multiple timeout values to better handle this
case, which previously assumed either a None or scalar value being
present.

Fixes: googleapis/python-bigquery#1612

* augment testing

* blacken and lint fixes

* unused import
parthea pushed a commit that referenced this pull request Apr 1, 2026
* chore: add tests for `to_gbq` with flexible column names

* just numbers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL