Add system tests for logging w/ insert_id/severty/http_request metdata. - #1682
Merged
tseaver merged 1 commit intoMar 30, 2016
Merged
Add system tests for logging w/ insert_id/severty/http_request metdata.#1682tseaver merged 1 commit into
tseaver merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
system_tests/logging_.py
| self.to_delete.append(logger) | ||
| logger.log_text(TEXT_PAYLOAD, insert_id=INSERT_ID, severity=SEVERITY, | ||
| http_request=REQUEST) | ||
| time.sleep(2) |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
* fix: AccessEntry API representation parsing Overriding the `AccessEntry#_properties` with a deep copy of the API resource overwrites the `role` property set in `AccessEntry.__init__` which isn't present in the resource if the `role` is set to `None`. This causes `AccessEntry`s generated from API representations to no longer evaluate to equal with equivalent `AccessEntry` resources instantiated through `AccessEntry.__init__`. The added unit test fails without the change and passes with the change. * build: formatting --------- Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.