chore: update goldens - #17632
Merged
parthea merged 1 commit intoJul 6, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies several integration golden files in the GAPIC generator, specifically removing the indentation for the string elements within the __lazy_modules__ set in multiple __init__.py files to align them with the left margin. There are no review comments, and I have no additional feedback to provide.
Sorry, something went wrong.
daniel-sanche
approved these changes
Jul 6, 2026
parthea
marked this pull request as ready for review
July 6, 2026 18:42
parthea
pushed a commit
that referenced
this pull request
Jul 13, 2026
This PR adds a new `Gapic Generator Specialized tests / status` check, and makes sure it always runs, regardless of whether the generator code was touched. This test is green if all gapic generator tests are skipped or passed, otherwise red This change allows us to mark gapic generator tests as required, so issues don't slip through (see #17632) This PR also uncovered an issue with fragment tests, where they were not being triggered properly, and addresses it as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the goldens following #17614. This PR is needed to unblock release PR #17600