feat(api-core): add get_universe_domain helper to universe.py - #17799
Merged
hebaalazzeh merged 5 commits intoJul 21, 2026
Merged
feat(api-core): add get_universe_domain helper to universe.py#17799hebaalazzeh merged 5 commits into
hebaalazzeh merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces helper functions get_universe_domain, get_default_mtls_endpoint, and get_api_endpoint in universe.py to handle universe domain resolution and mTLS endpoint conversion, along with corresponding unit tests. Feedback was provided to avoid using hardcoded magic numbers (-23 and -15) when slicing the host string in get_default_mtls_endpoint, suggesting dynamic calculation based on suffix lengths instead.
Sorry, something went wrong.
Comment thread
packages/google-api-core/google/api_core/universe.py
Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
daniel-sanche
approved these changes
Jul 21, 2026
This was referenced Jul 21, 2026
Closed
Merged
This was referenced Jul 21, 2026
hebaalazzeh
added a commit
that referenced
this pull request
Jul 30, 2026
This PR refactors the generated client templates to utilize centralized endpoint routing and universe domain logic. * **Helper Relocation**: Moved `_get_default_mtls_endpoint`, `_get_api_endpoint`, and `_get_universe_domain` from generated client classes to the compatibility layer (`_compat.py`). * **Backward Compatibility**: Implemented these helpers locally in `_compat.py` to maintain compatibility with older `google-api-core` versions, laying groundwork for importing directly from `google.api_core.universe` (centralized in PR #17799) once the minimum dependency is bumped. * **Test Migration**: Moved unit tests for these routing functions from `test_%service.py.j2` to `test_compat.py.j2`. Towards: #17883
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR consolidates and centralizes all universe-related configuration helpers and routing logic into google/api_core/universe.py. This avoids polluting gapic_v1 with duplicate routing logic and keeps universe/endpoint utilities unified.
Changes: