| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
This pull request restructures the samples directory of the google-cloud-bigtable package, organizing samples into subdirectories such as admin_client, data_client_async, and legacy_client. This restructuring is reflected in updates to integration configurations, documentation configuration, and contributing guidelines. I have no feedback to provide.
Sorry, something went wrong.
Sorry, something went wrong.
|
Wait for #17880 to be merged Done. Please merge main into this branch |
Sorry, something went wrong.
|
@daniel-sanche We also need the fix in #17909. Please can you merge main into this branch again? |
Sorry, something went wrong.
| packages/google-cloud-bigtable/samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_update_schema_bundle_sync.py, | ||
| packages/google-cloud-bigtable/samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_update_table_async.py, | ||
| packages/google-cloud-bigtable/samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_update_table_sync.py, | ||
| packages/google-cloud-bigtable/samples/admin_client/generated_samples/bigtableadmin_v2_generated_bigtable_instance_admin_create_app_profile_async.py, |
There was a problem hiding this comment.
It's not currently possible to change the directory for auto-generated samples. The output directory is hard-coded in gapic-generator as "samples/generated_samples"Can you propose a change to gapic-generator to add an option to customize the location?
Sorry, something went wrong.
There was a problem hiding this comment.
That's too bad, I thought this was something we could customize.
If it's just bigtable, I don't think we need to prioritize a new feature for this. But if we can think of other use-cases, we can plan to do something for this in S2
For now, I reverted the move for the generated samples
Sorry, something went wrong.
| "**/.nox/**/*", | ||
| "samples/AUTHORING_GUIDE.md", | ||
| "samples/CONTRIBUTING.md", | ||
| "samples/snippets/README.rst", |
There was a problem hiding this comment.
This is part of the generated code. If it's not critical, can we revert it?
If want to remove it, the change should be made in gapic-generator first.
Sorry, something went wrong.
There was a problem hiding this comment.
Good catch, reverted
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR re-organizes the sampes directory, to group files by client.
The change is easier to view by browsing the directory, rather than reading the diff: https://github.com/googleapis/google-cloud-python/tree/samples_1_reorganize_samples/packages/google-cloud-bigtable/samples