FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(bigtable): reorganize samples by daniel-sanche · Pull Request #17819 · googleapis/google-cloud-python · GitHub

chore(bigtable): reorganize samples - #17819

Merged
parthea merged 9 commits into
mainfrom
samples_1_reorganize_samples
Aug 12, 2026
Merged

chore(bigtable): reorganize samples#17819
parthea merged 9 commits into
mainfrom
samples_1_reorganize_samples

Conversation

Copy link
Copy Markdown
Contributor

This PR re-organizes the sampes directory, to group files by client.

The change is easier to view by browsing the directory, rather than reading the diff: https://github.com/googleapis/google-cloud-python/tree/samples_1_reorganize_samples/packages/google-cloud-bigtable/samples

daniel-sanche requested review from a team as code owners July 21, 2026 23:21

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request restructures the samples directory of the google-cloud-bigtable package, organizing samples into subdirectories such as admin_client, data_client_async, and legacy_client. This restructuring is reflected in updates to integration configurations, documentation configuration, and contributing guidelines. I have no feedback to provide.

snippet-bot Bot commented Jul 21, 2026
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 125 region tags. You are about to delete 125 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

parthea commented Jul 23, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Wait for #17880 to be merged

Done. Please merge main into this branch

parthea marked this pull request as draft July 24, 2026 18:48
daniel-sanche marked this pull request as ready for review July 25, 2026 00:14

parthea commented Jul 27, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

@daniel-sanche We also need the fix in #17909. Please can you merge main into this branch again?

parthea marked this pull request as draft July 27, 2026 19:20
daniel-sanche marked this pull request as ready for review August 3, 2026 23:35
parthea assigned parthea and unassigned daniel-sanche Aug 4, 2026
packages/google-cloud-bigtable/samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_update_schema_bundle_sync.py,
packages/google-cloud-bigtable/samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_update_table_async.py,
packages/google-cloud-bigtable/samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_update_table_sync.py,
packages/google-cloud-bigtable/samples/admin_client/generated_samples/bigtableadmin_v2_generated_bigtable_instance_admin_create_app_profile_async.py,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's not currently possible to change the directory for auto-generated samples. The output directory is hard-coded in gapic-generator as "samples/generated_samples"Can you propose a change to gapic-generator to add an option to customize the location?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That's too bad, I thought this was something we could customize.

If it's just bigtable, I don't think we need to prioritize a new feature for this. But if we can think of other use-cases, we can plan to do something for this in S2

For now, I reverted the move for the generated samples

parthea assigned daniel-sanche and unassigned parthea Aug 4, 2026
"**/.nox/**/*",
"samples/AUTHORING_GUIDE.md",
"samples/CONTRIBUTING.md",
"samples/snippets/README.rst",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is part of the generated code. If it's not critical, can we revert it?

If want to remove it, the change should be made in gapic-generator first.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch, reverted

parthea enabled auto-merge (squash) August 12, 2026 01:22
parthea merged commit 9f1477c into main Aug 12, 2026
55 checks passed
parthea deleted the samples_1_reorganize_samples branch August 12, 2026 01:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL