Tolerate timestamps w/ truncated nanos. - #1785
Merged
tseaver merged 2 commits intoMay 12, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
gcloud/test__helpers.py
| with self.assertRaises(ValueError): | ||
| self._callFUT(dt_str) | ||
| truncateds_and_micros = [ | ||
| ('12345678', 123456), |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
I don't have the bandwidth right now to follow this properly, but have you guys looked at the proto3 JSON mapping spec for Timestamp and the Timestamp class in google.protobuf. Could we use that library's support for JSON serialization and deserialization of the well-known type Timestamp? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Possibly, the phrase
may actually shed some light on what we've seen empirically. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@dhermes Seems like you didn't find a counter-example to the "truncate/floor to micros" bit. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Yeah LGTM |
Sorry, something went wrong.
Merged
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
…tamp_params.py` (#1785) * Updates file * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Correcting RowIterator * Correcting variable names --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Tim Swast <swast@google.com>
chalmerlowe
pushed a commit
that referenced
this pull request
Mar 26, 2026
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos. BEGIN_COMMIT BEGIN_NESTED_COMMIT feat: Added a new field `ComposeObjectRequest.delete_source_objects` field PiperOrigin-RevId: 863087065 Library-IDs: google-cloud-storage Source-link: [googleapis/googleapis@51ff87f4](googleapis/googleapis@51ff87f4) END_NESTED_COMMIT BEGIN_NESTED_COMMIT docs: Updated documentation for `BidiReadObject`, `ReadObjectRequest`, and `ObjectContexts` PiperOrigin-RevId: 863087065 Library-IDs: google-cloud-storage Source-link: [googleapis/googleapis@51ff87f4](googleapis/googleapis@51ff87f4) END_NESTED_COMMIT END_COMMIT This pull request is generated with proto changes between [googleapis/googleapis@5400ccce](googleapis/googleapis@5400ccc) (exclusive) and [googleapis/googleapis@51ff87f4](googleapis/googleapis@51ff87f) (inclusive). Librarian Version: v1.0.2-0.20260309131826-42ac5c451239 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8e2c32496077054105bd06c54a59d6a6694287bc053588e24debe6da6920ad91
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
… inconsistency with pandas (#1785) * fix: read_csv with both index_col and use_cols inconsistent with pandas * ensure columns is not list type and avoid flacky ordered of columns * add docstring for index_col_in_columns and fix tests --------- Co-authored-by: Tim Sweña (Swast) <swast@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1783.