chore(generator): add remove unused import script - #17917
Merged
ohmayr merged 2 commits intoJul 27, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…te remov…" This reverts commit 395f764.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the GAPIC generator templates for unit tests to use method.ref_types instead of method.flat_ref_types when generating imports. This change results in additional protobuf and type imports being generated in the unit tests, as reflected in the updated golden files. Additionally, a post-processing configuration is added to remove specific unused imports from certain generated tests. I have no feedback to provide as there are no review comments.
Sorry, something went wrong.
hebaalazzeh
approved these changes
Jul 27, 2026
hebaalazzeh
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewers2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the post processing script back until we bump the generator