FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ndb): avoid unbound lock in delete callback by lyushher · Pull Request #17969 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

fix(ndb): avoid unbound lock in delete callback - #17969

Merged
parthea merged 4 commits into
googleapis:mainfrom
lyushher:fix-17926-ndb-delete-lock
Aug 14, 2026
ConversationCommits (4)ChecksFiles changed
Merged

fix(ndb): avoid unbound lock in delete callback#17969
parthea merged 4 commits into
googleapis:mainfrom
lyushher:fix-17926-ndb-delete-lock

Conversation

lyushher commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR fixes a NameError that occurs when ndb.delete() is called with use_datastore=False inside a transaction while the global cache is enabled.

The transaction completion callback can reference lock even though no lock is acquired when datastore writes are disabled.

Changes

  • Avoid registering the unlock callback when no lock has been acquired.
  • Add a regression test covering this scenario.

Testing

python -m pytest tests/unit/test__datastore_api.py -v

All 78 tests passed.

Fixes #17926

lyushher requested a review from a team as a code owner August 1, 2026 15:21
gemini-code-assist Bot reviewed Aug 1, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request updates the delete function in _datastore_api.py to handle cases where a global cache lock is not acquired, particularly when a transaction is active but the datastore is not used. It also adds a corresponding unit test to verify this behavior. The review feedback suggests making the lock check more explicit by using if lock is not None: instead of if lock: to prevent potential issues with falsy values.

Comment thread packages/google-cloud-ndb/google/cloud/ndb/_datastore_api.py Outdated
parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 4, 2026
parthea self-assigned this Aug 4, 2026
yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 4, 2026
parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 4, 2026
yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 4, 2026

parthea commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Hi @lyushher,

Thanks for opening a PR! Please could you resolve the minor coverage gap?

google/cloud/ndb/_datastore_api.py              400      0    138      1    99%   465->exit

parthea assigned lyushher and unassigned parthea Aug 4, 2026
parthea assigned parthea and unassigned lyushher Aug 12, 2026
parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 14, 2026
yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 14, 2026
parthea approved these changes Aug 14, 2026
View reviewed changes

parthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @lyushher!

parthea removed their assignment Aug 14, 2026
parthea enabled auto-merge (squash) August 14, 2026 15:28
parthea merged commit c513b39 into googleapis:main Aug 14, 2026
44 of 45 checks passed
release-please Bot mentioned this pull request Aug 14, 2026
Merged
codyoss pushed a commit that referenced this pull request Aug 24, 2026
chore: release main (#18013)
3e29682 
🤖 I have created a release *beep* *boop*
---


<details><summary>django-google-spanner: 5.0.1</summary>

##
[5.0.1](django-google-spanner-v5.0.0...django-google-spanner-v5.0.1)
(2026-08-21)


### Bug Fixes

* **django-spanner:** declare django dependency in setup.py
([#18044](#18044))
([c341469](c341469))


### Documentation

* **django-spanner, common-protos:** centralize CONTRIBUTING.rst
pointers
([#18041](#18041))
([2b056ab](2b056ab))
</details>

<details><summary>gapic-generator: 1.39.0</summary>

##
[1.39.0](gapic-generator-v1.38.0...gapic-generator-v1.39.0)
(2026-08-21)


### Features

* **generator:** add fallback compatibility imports for google-api-core
helpers
([#17999](#17999))
([9c13ae2](9c13ae2))


### Bug Fixes

* **generator:** check for api_version header in metadata list
([#18015](#18015))
([0e63510](0e63510))
* **generator:** move version checks after __all__ in __init__.py
temlate
([#18100](#18100))
([d0efb4d](d0efb4d))
* **generator:** switch core_deps_from_source to DEFAULT_PYTHON_VERSION
([#18050](#18050))
([895ffa2](895ffa2))


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>gcp-sphinx-docfx-yaml: 3.3.2</summary>

##
[3.3.2](gcp-sphinx-docfx-yaml-v3.3.1...gcp-sphinx-docfx-yaml-v3.3.2)
(2026-08-21)


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-ads-admanager: 0.10.2</summary>

##
[0.10.2](google-ads-admanager-v0.10.1...google-ads-admanager-v0.10.2)
(2026-08-21)


### Features

* update googleapis and regenerate
([#18087](#18087))
([db1622a](db1622a))
</details>

<details><summary>google-ads-datamanager: 0.9.2</summary>

##
[0.9.2](google-ads-datamanager-v0.9.1...google-ads-datamanager-v0.9.2)
(2026-08-21)


### Features

* update googleapis and regenerate
([#18087](#18087))
([db1622a](db1622a))
</details>

<details><summary>google-api-core: 2.35.0</summary>

##
[2.35.0](google-api-core-v2.34.0...google-api-core-v2.35.0)
(2026-08-21)


### Features

* **api_core:** add deprecation warning for grpcio &lt; 1.83.0 for PQC
([#18045](#18045))
([7e2e23e](7e2e23e))


### Bug Fixes

* **api_core:** improve rest path validation
([#17753](#17753))
([63bfb96](63bfb96))
* **api_core:** support suppress_metrics_header fallback in
AuthMetadataPlugin
([#18029](#18029))
([dd2000d](dd2000d))


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-apps-chat: 0.10.5</summary>

##
[0.10.5](google-apps-chat-v0.10.4...google-apps-chat-v0.10.5)
(2026-08-21)


### Features

* update googleapis and regenerate
([#18087](#18087))
([db1622a](db1622a))
* update sources and regenerate
([#18164](#18164))
([5ff8274](5ff8274))
</details>

<details><summary>google-auth: 2.57.0</summary>

##
[2.57.0](google-auth-v2.56.3...google-auth-v2.57.0)
(2026-08-21)


### Features

* **auth:** add deprecation warning for grpcio &lt; 1.83.0 (PQC support)
([#18070](#18070))
([68bdaba](68bdaba))


### Bug Fixes

* **auth:** parse hostname for mTLS and PSC endpoint certificate rotat…
([#18153](#18153))
([b642373](b642373))
* **auth:** prevent TypeError and support home-dir cert fallback for X…
([#18016](#18016))
([b9a1379](b9a1379))


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-auth-httplib2: 0.4.2</summary>

##
[0.4.2](google-auth-httplib2-v0.4.1...google-auth-httplib2-v0.4.2)
(2026-08-21)


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-auth-oauthlib: 1.4.1</summary>

##
[1.4.1](google-auth-oauthlib-v1.4.0...google-auth-oauthlib-v1.4.1)
(2026-08-21)


### Bug Fixes

* **google-auth-oauthlib:** prevent port re-use on windows
([#18166](#18166))
([e20796a](e20796a))


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-alloydb: 0.11.1</summary>

##
[0.11.1](google-cloud-alloydb-v0.11.0...google-cloud-alloydb-v0.11.1)
(2026-08-21)


### Features

* update sources and regenerate
([#18164](#18164))
([5ff8274](5ff8274))
</details>

<details><summary>google-cloud-audit-log: 0.6.2</summary>

##
[0.6.2](google-cloud-audit-log-v0.6.1...google-cloud-audit-log-v0.6.2)
(2026-08-21)


### Bug Fixes

* `google-cloud-audit-log` wheel installs unintended top-level `docs`
package
([#17271](#17271))
([ad99ed1](ad99ed1))
</details>

<details><summary>google-cloud-auditmanager: 0.3.1</summary>

##
[0.3.1](google-cloud-auditmanager-v0.3.0...google-cloud-auditmanager-v0.3.1)
(2026-08-21)


### Features

* update googleapis and regenerate
([#18087](#18087))
([db1622a](db1622a))
* update sources and regenerate
([#18164](#18164))
([5ff8274](5ff8274))
</details>

<details><summary>google-cloud-automl: 2.20.1</summary>

##
[2.20.1](google-cloud-automl-v2.20.0...google-cloud-automl-v2.20.1)
(2026-08-21)


### Bug Fixes

* **automl:** remove unused libcst extra and constraints
([#18056](#18056))
([9ba4449](9ba4449))
</details>

<details><summary>google-cloud-bigquery: 3.44.0</summary>

##
[3.44.0](google-cloud-bigquery-v3.43.0...google-cloud-bigquery-v3.44.0)
(2026-08-21)


### Features

* add PendingDeprecationWarning for to_dataframe and to_arrow conversion
methods
([#18021](#18021))
([6bebf30](6bebf30))
* **bigquery:** add PendingDeprecationWarning for from_dataframe methods
([#18048](#18048))
([b84b754](b84b754))
* **bigquery:** support queryResultsFormat and compressionCodec in
query_and_wait
([#18027](#18027))
([d172408](d172408))
* check python and dependency versions in bigquery and ndb
([#18075](#18075))
([62ff6f3](62ff6f3))


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-bigquery-reservation: 1.26.0</summary>

##
[1.26.0](google-cloud-bigquery-reservation-v1.25.0...google-cloud-bigquery-reservation-v1.26.0)
(2026-08-21)


### Features

* update googleapis and regenerate
([#18087](#18087))
([db1622a](db1622a))
</details>

<details><summary>google-cloud-bigquery-storage: 2.41.0</summary>

##
[2.41.0](google-cloud-bigquery-storage-v2.40.0...google-cloud-bigquery-storage-v2.41.0)
(2026-08-21)


### Features

* add pandas-gbq to optional extras
([#18020](#18020))
([fe91d93](fe91d93))
* **bigquery-storage:** add deprecation warning for to_dataframe
([#18022](#18022))
([57e7822](57e7822))
* update sources and regenerate
([#18164](#18164))
([5ff8274](5ff8274))


### Bug Fixes

* **storage:** support updated GapicCallable metadata in tests
([#18031](#18031))
([24fe2e3](24fe2e3))


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-bigtable: 2.43.0</summary>

##
[2.43.0](google-cloud-bigtable-v2.42.0...google-cloud-bigtable-v2.43.0)
(2026-08-21)


### Features

* update sources and regenerate
([#18164](#18164))
([5ff8274](5ff8274))


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-build: 3.39.0</summary>

##
[3.39.0](google-cloud-build-v3.38.1...google-cloud-build-v3.39.0)
(2026-08-21)


### Features

* update sources and regenerate
([#18164](#18164))
([5ff8274](5ff8274))
</details>

<details><summary>google-cloud-commerceproducer: 0.1.2</summary>

##
[0.1.2](google-cloud-commerceproducer-v0.1.1...google-cloud-commerceproducer-v0.1.2)
(2026-08-21)


### Features

* update googleapis and regenerate
([#18087](#18087))
([db1622a](db1622a))
</details>

<details><summary>google-cloud-compute: 1.51.0</summary>

##
[1.51.0](google-cloud-compute-v1.50.0...google-cloud-compute-v1.51.0)
(2026-08-21)


### Features

* update googleapis and regenerate
([#18087](#18087))
([db1622a](db1622a))
</details>

<details><summary>google-cloud-compute-v1beta: 0.12.2</summary>

##
[0.12.2](google-cloud-compute-v1beta-v0.12.1...google-cloud-compute-v1beta-v0.12.2)
(2026-08-21)


### Features

* update googleapis and regenerate
([#18087](#18087))
([db1622a](db1622a))
</details>

<details><summary>google-cloud-core: 2.7.0</summary>

##
[2.7.0](google-cloud-core-v2.6.1...google-cloud-core-v2.7.0)
(2026-08-21)


### Features

* **core:** implement PEP 0810 explicit lazy imports in
google-cloud-core
([#18052](#18052))
([5a7ed02](5a7ed02))


### Bug Fixes

* use lowercase x-goog-api-client header
([#18064](#18064))
([d465d1e](d465d1e))


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-dataform: 0.11.3</summary>

##
[0.11.3](google-cloud-dataform-v0.11.2...google-cloud-dataform-v0.11.3)
(2026-08-21)


### Features

* update googleapis and regenerate
([#18087](#18087))
([db1622a](db1622a))
* update sources and regenerate
([#18164](#18164))
([5ff8274](5ff8274))
</details>

<details><summary>google-cloud-datastore: 2.26.1</summary>

##
[2.26.1](google-cloud-datastore-v2.26.0...google-cloud-datastore-v2.26.1)
(2026-08-21)


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-dns: 0.37.1</summary>

##
[0.37.1](google-cloud-dns-v0.37.0...google-cloud-dns-v0.37.1)
(2026-08-21)


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-documentai-toolbox: 0.17.3</summary>

##
[0.17.3](google-cloud-documentai-toolbox-v0.17.2...google-cloud-documentai-toolbox-v0.17.3)
(2026-08-21)


### Bug Fixes

* **documentai-toolbox:** contain split_pdf output to output_path
([#18063](#18063))
([d206212](d206212))
* **documentai-toolbox:** enable autoescape in export_hocr_str
([#18140](#18140))
([0d671d2](0d671d2))


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-error-reporting: 1.16.1</summary>

##
[1.16.1](google-cloud-error-reporting-v1.16.0...google-cloud-error-reporting-v1.16.1)
(2026-08-21)


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-firestore: 2.29.0</summary>

##
[2.29.0](google-cloud-firestore-v2.28.1...google-cloud-firestore-v2.29.0)
(2026-08-21)


### Features

* update googleapis and regenerate
([#18087](#18087))
([db1622a](db1622a))


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-iam: 2.25.0</summary>

##
[2.25.0](google-cloud-iam-v2.24.1...google-cloud-iam-v2.25.0)
(2026-08-21)


### Features

* update googleapis and regenerate
([#18087](#18087))
([db1622a](db1622a))
</details>

<details><summary>google-cloud-logging: 3.16.3</summary>

##
[3.16.3](google-cloud-logging-v3.16.2...google-cloud-logging-v3.16.3)
(2026-08-21)


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-monitoring-dashboards: 3.0.0</summary>

##
[3.0.0](google-cloud-monitoring-dashboards-v2.22.0...google-cloud-monitoring-dashboards-v3.0.0)
(2026-08-21)


### ⚠ BREAKING CHANGES

* Remove erroneous google/monitoring/dashboard clients
([#18165](#18165))

### Bug Fixes

* Remove erroneous google/monitoring/dashboard clients
([#18165](#18165))
([fb0c1b9](fb0c1b9))
</details>

<details><summary>google-cloud-ndb: 2.6.0</summary>

##
[2.6.0](google-cloud-ndb-v2.5.1...google-cloud-ndb-v2.6.0)
(2026-08-21)


### Features

* check python and dependency versions in bigquery and ndb
([#18075](#18075))
([62ff6f3](62ff6f3))


### Bug Fixes

* **ndb:** avoid unbound lock in delete callback
([#17969](#17969))
([c513b39](c513b39))
* **ndb:** use the single-argument generator.throw() signature
([#18159](#18159))
([dfb0e36](dfb0e36))


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-oracledatabase: 0.6.2</summary>

##
[0.6.2](google-cloud-oracledatabase-v0.6.1...google-cloud-oracledatabase-v0.6.2)
(2026-08-21)


### Features

* update googleapis and regenerate
([#18087](#18087))
([db1622a](db1622a))
</details>

<details><summary>google-cloud-pubsub: 2.39.2</summary>

##
[2.39.2](google-cloud-pubsub-v2.39.1...google-cloud-pubsub-v2.39.2)
(2026-08-21)


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-recaptcha-enterprise: 1.33.0</summary>

##
[1.33.0](google-cloud-recaptcha-enterprise-v1.32.0...google-cloud-recaptcha-enterprise-v1.33.0)
(2026-08-21)


### Features

* update googleapis and regenerate
([#18087](#18087))
([db1622a](db1622a))
</details>

<details><summary>google-cloud-retail: 2.12.0</summary>

##
[2.12.0](google-cloud-retail-v2.11.0...google-cloud-retail-v2.12.0)
(2026-08-21)


### Features

* update googleapis and regenerate
([#18087](#18087))
([db1622a](db1622a))
</details>

<details><summary>google-cloud-runtimeconfig: 0.37.1</summary>

##
[0.37.1](google-cloud-runtimeconfig-v0.37.0...google-cloud-runtimeconfig-v0.37.1)
(2026-08-21)


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-spanner: 3.70.0</summary>

##
[3.70.0](google-cloud-spanner-v3.69.1...google-cloud-spanner-v3.70.0)
(2026-08-21)


### Features

* check python and dependency versions in spanner packages
([#18177](#18177))
([b4d9717](b4d9717))
* **spanner:** add DataBoost and auto_partition_mode support to DBAPI
driver
([#18161](#18161))
([5bc3899](5bc3899))


### Bug Fixes

* **spanner:** buffer returned rows in autocommit DML statements
([#18152](#18152))
([7f8a552](7f8a552))


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-storage: 3.14.0</summary>

##
[3.14.0](google-cloud-storage-v3.13.1...google-cloud-storage-v3.14.0)
(2026-08-21)


### Features

* **storage:** expose metadata parameter in asyncio gRPC calls
([#17634](#17634))
([aaa263d](aaa263d))
* **storage:** expose object_metadata on AsyncMultiRangeDownloader
([#17411](#17411))
([a0171ae](a0171ae))


### Bug Fixes

* **storage:** add retry support for finalize and close in
AsyncAppendableObjectWriter
([#17733](#17733))
([92bb6dc](92bb6dc))
* **storage:** ensure bidi-gRPC stream is cleaned up on open failure and
close
([#18119](#18119))
([ac0dfd1](ac0dfd1))
* **storage:** resume bidi reads after idle-stream aborts
([#18061](#18061))
([3fe1e21](3fe1e21))
* use lowercase x-goog-api-client header
([#18064](#18064))
([d465d1e](d465d1e))


### Documentation

* correct typos and grammar in README
([#16535](#16535))
([593a8b0](593a8b0))
* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-storage-control: 1.14.0</summary>

##
[1.14.0](google-cloud-storage-control-v1.13.0...google-cloud-storage-control-v1.14.0)
(2026-08-21)


### Features

* update googleapis and regenerate
([#18087](#18087))
([db1622a](db1622a))
</details>

<details><summary>google-cloud-support: 0.5.3</summary>

##
[0.5.3](google-cloud-support-v0.5.2...google-cloud-support-v0.5.3)
(2026-08-21)


### Features

* update sources and regenerate
([#18164](#18164))
([5ff8274](5ff8274))
</details>

<details><summary>google-cloud-testutils: 1.9.3</summary>

##
[1.9.3](google-cloud-testutils-v1.9.2...google-cloud-testutils-v1.9.3)
(2026-08-21)


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>google-cloud-vectorsearch: 0.11.2</summary>

##
[0.11.2](google-cloud-vectorsearch-v0.11.1...google-cloud-vectorsearch-v0.11.2)
(2026-08-21)


### Features

* update googleapis and regenerate
([#18087](#18087))
([db1622a](db1622a))
</details>

<details><summary>google-devicesandservices-health: 0.1.2</summary>

##
[0.1.2](google-devicesandservices-health-v0.1.1...google-devicesandservices-health-v0.1.2)
(2026-08-21)


### Features

* update sources and regenerate
([#18164](#18164))
([5ff8274](5ff8274))
</details>

<details><summary>google-resumable-media: 2.10.2</summary>

##
[2.10.2](google-resumable-media-v2.10.1...google-resumable-media-v2.10.2)
(2026-08-21)


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>googleapis-common-protos: 1.75.2</summary>

##
[1.75.2](googleapis-common-protos-v1.75.1...googleapis-common-protos-v1.75.2)
(2026-08-21)


### Documentation

* **django-spanner, common-protos:** centralize CONTRIBUTING.rst
pointers
([#18041](#18041))
([2b056ab](2b056ab))
</details>

<details><summary>pandas-gbq: 0.35.2</summary>

##
[0.35.2](pandas-gbq-v0.35.1...pandas-gbq-v0.35.2)
(2026-08-21)


### Bug Fixes

* **pandas-gbq:** reject backticks in parse_table_id
([#18156](#18156))
([f687060](f687060))
</details>

<details><summary>proto-plus: 1.28.4</summary>

##
[1.28.4](proto-plus-v1.28.3...proto-plus-v1.28.4)
(2026-08-21)


### Documentation

* **handwritten:** centralize CONTRIBUTING.rst pointers
([#17642](#17642))
([23b9499](23b9499))
</details>

<details><summary>sqlalchemy-spanner: 1.20.0</summary>

##
[1.20.0](sqlalchemy-spanner-v1.19.0...sqlalchemy-spanner-v1.20.0)
(2026-08-21)


### Features

* **sqlalchemy-spanner:** export MAX_SIZE constant
([#17922](#17922))
([e15c21d](e15c21d))
* **sqlalchemy-spanner:** native UUID data type support in dialect
([#17913](#17913))
([6431932](6431932))


### Bug Fixes

* bump sqlparse from 0.5.5 to 0.6.0 in /packages/sqlalchemy-spanner
([#18136](#18136))
([3ba7d02](3ba7d02))
* **sqlalchemy-spanner:** fix get_multi_indexes crash on SEARCH indexes
([#17907](#17907))
([5b2da81](5b2da81))
* **sqlalchemy-spanner:** register TOKENLIST in _type_map for reflection
([#17911](#17911))
([788208b](788208b))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

daniel-sanche daniel-sanche approved these changes
parthea parthea approved these changes
+1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

google-cloud-ndb unsafe access of free variable 'lock'

4 participants

Back | FazBrowse Home | New Git URL