docs(bigquery): update load_table_dataframe code sample to use BigFrames - #18036
Closed
shuoweil wants to merge 2 commits into
Closed
docs(bigquery): update load_table_dataframe code sample to use BigFrames#18036shuoweil wants to merge 2 commits into
shuoweil wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the test_init_default_client_info unit test in test_read_client_v1.py to mock wrap_method and verify that the client info is correctly passed and formatted. Feedback was provided to rename the local variable client_info to avoid shadowing the imported module of the same name.
Sorry, something went wrong.
Comment thread
packages/google-cloud-bigquery-storage/tests/unit/test_read_client_v1.py
Outdated
…ient_v1.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
Author
|
This fix has been merged in #17938 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the bigquery_load_table_dataframe code sample (which powers cloud.google.com/bigquery/docs/samples/bigquery-load-table-dataframe) to use BigQuery DataFrames (bigframes) instead of the legacy client.load_table_from_dataframe API.
Fixes #<522898394> 🦕