chore(automl): mock AutoMlClient in test_predicition_client_client_info - #18068
Merged
parthea merged 1 commit intoAug 11, 2026
Merged
chore(automl): mock AutoMlClient in test_predicition_client_client_info#18068parthea merged 1 commit into
parthea merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the unit test test_prediction_client_client_info in test_tables_client_v1beta1.py to mock and pass a client argument when instantiating TablesClient. There are no review comments, and I have no feedback to provide.
Sorry, something went wrong.
parthea
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #17616, google-api-core extracts and deduplicates the x-goog-api-client metrics header during callable construction in _GapicCallable.__init__ (_extract_metrics_header). Because AutoMlClient was not mocked in this test, passing client_info=mock.Mock() caused AutoMlClient's transport wrapper to attempt unpacking the mock metadata into (key, value) pairs, resulting in: