FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(google/cloud/ftp/v1): add google-cloud-ftp by JoeWang1127 · Pull Request #18104 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

feat(google/cloud/ftp/v1): add google-cloud-ftp - #18104

Merged
ohmayr merged 1 commit into
googleapis:mainfrom
JoeWang1127:onboard-new-library-2026-08-13-google/cloud/ftp/v1
Aug 13, 2026
ConversationCommits (1)ChecksFiles changed
Merged

feat(google/cloud/ftp/v1): add google-cloud-ftp#18104
ohmayr merged 1 commit into
googleapis:mainfrom
JoeWang1127:onboard-new-library-2026-08-13-google/cloud/ftp/v1

Conversation

JoeWang1127 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

b/543713113

PiperOrigin-RevId: 960764304

JoeWang1127 requested review from a team as code owners August 13, 2026 14:47

snippet-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 12 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

gemini-code-assist Bot reviewed Aug 13, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request introduces the new google-cloud-ftp Python client library, including its generated GAPIC client, documentation, samples, and testing configurations. The review identified critical issues with non-existent dependency versions specified in the configuration files: grpcio is pinned to a non-existent version 1.75.1 in both setup.py and noxfile.py, and ruff is pinned to a non-existent version 0.14.14 in noxfile.py. These invalid versions must be updated to valid, existing PyPI releases to prevent installation and testing failures.

Comment thread packages/google-cloud-ftp/setup.py
# See https://github.com/googleapis/google-cloud-python/issues/12364
"google-auth >= 2.14.1, <3.0.0,!=2.24.0,!=2.25.0",
"grpcio >= 1.59.0, < 2.0.0",
"grpcio >= 1.75.1, < 2.0.0; python_version >= '3.14'",

gemini-code-assist Bot Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The version 1.75.1 of grpcio does not exist on PyPI. Specifying a non-existent version will cause installation failures. Please update it to a valid version like 1.65.1.

Suggested change
"grpcio >= 1.75.1, < 2.0.0; python_version >= '3.14'",
"grpcio >= 1.65.1, < 2.0.0",
References
  1. When defining dependency constraints in setup.py, ensure they align with the released gapic-generator templates and do not add redundant environment markers.

Comment thread packages/google-cloud-ftp/noxfile.py

import nox

RUFF_VERSION = "ruff==0.14.14"

gemini-code-assist Bot Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The version 0.14.14 of ruff does not exist on PyPI. Specifying a non-existent version will cause nox to fail when setting up the linting and formatting environments. Please update it to a valid version like 0.4.14.

Suggested change
RUFF_VERSION = "ruff==0.14.14"
RUFF_VERSION = "ruff==0.4.14"

Comment thread packages/google-cloud-ftp/noxfile.py

def install_systemtest_dependencies(session, *constraints):
if session.python >= "3.12":
session.install("--pre", "grpcio>=1.75.1")

gemini-code-assist Bot Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The version 1.75.1 of grpcio does not exist on PyPI. This will cause the unit test session to fail on Python 3.12+ because pip cannot find a matching version. Please update it to a valid version like 1.65.1.

Suggested change
session.install("--pre", "grpcio>=1.75.1")
session.install("--pre", "grpcio>=1.65.1")

ohmayr merged commit 60979ce into googleapis:main Aug 13, 2026
46 checks passed
release-please Bot mentioned this pull request Aug 13, 2026
Merged
ohmayr pushed a commit that referenced this pull request Aug 13, 2026
chore(main): release google-cloud-ftp 0.1.0 (#18107)
db075a8 
🤖 I have created a release *beep* *boop*
---


## 0.1.0 (2026-08-13)


### Features

* **google/cloud/ftp/v1:** add google-cloud-ftp
([#18104](#18104))
([60979ce](60979ce))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ohmayr ohmayr approved these changes
+1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL