chore(tests): improve unit test output - #18123
Open
daniel-sanche wants to merge 14 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces real-time log streaming in the CI test runner when running with a single worker, while maintaining buffered logs for parallel execution. It also adds a global autouse fixture to mock the MetricServiceClient in unit tests and ensures proper cleanup of GoogleCloudMetricsHandler instances using try-finally blocks. Feedback is provided regarding a potential bash error in the test runner script when checking the PARALLEL_WORKERS variable if it is unset or empty.
Sorry, something went wrong.
Comment thread
ci/run_conditional_tests.sh
Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
daniel-sanche
marked this pull request as ready for review
August 14, 2026 23:11
daniel-sanche
marked this pull request as draft
August 17, 2026 22:25
daniel-sanche
marked this pull request as ready for review
August 20, 2026 00:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
Assignees
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #18122, the tests would stall without any logs after Running tests across 1 package(s) using 1 parallel worker(s)...
This is because the unit test job would wait until tests were complete before printing outputs, which isn't helpful when a job freezes
This PR attempts to improve the usability of unit tests by: